Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid redeemable_type value #3697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use valid redeemable_type value #3697

wants to merge 1 commit into from

Conversation

marklevi
Copy link
Contributor

Use valid redeemable_type (gift-card vs gift_card) in the extension-to-toml tests

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@marklevi marklevi added the #gsd:37340 Shopify CLI Payment Apps Support label Apr 11, 2024
@marklevi marklevi self-assigned this Apr 11, 2024
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@marklevi marklevi requested a review from bazay April 11, 2024 15:13
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.31% 6929/9582
🟡 Branches 69.44% 3406/4905
🟡 Functions 71.3% 1853/2599
🟡 Lines 73.51% 6530/8883

Test suite run success

1654 tests passing in 765 suites.

Report generated by 🧪jest coverage report action from aa9859b

@marklevi marklevi added this pull request to the merge queue Apr 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:37340 Shopify CLI Payment Apps Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants