Add 'cross-env' to dependencies

[fluturecode]

Changes

1. Moved cross-env to a dependency.

Purpose

This will allow [yarn start] to run correctly with no errors.

Learning

Please visit the comments from Issue #233 .

Testing

1. Pull in the changes to your local copy of this branch.
2. Run [yarn start] and make sure there are no errors.

Screenshot

References #233

[michaelachrisco]

Excellent, thanks for fixing that! We really should be adding any dependency that is necessary for running the project into the main dependencies.

[AramayisO]

I'm not sure we need to make cross-env a dependency since it is only used for development. Setting environment variables with cross-env can only work when you run the app using the development server. Once you run yarn build and create a production build, the app is turned into static files and there are no more "environment variables" - all variables get hard-coded in the source code. I think the problem in issue #233 is related to something else. I had that problem once, but then pulled down a clean branch and ran yarn install && yarn start and the app worked without problems.

[fluturecode]

I'm not sure we need to make cross-env a dependency since it is only used for development. Setting environment variables with cross-env can only work when you run the app using the development server. Once you run yarn build and create a production build, the app is turned into static files and there are no more "environment variables" - all variables get hard-coded in the source code. I think the problem in issue #233 is related to something else. I had that problem once, but then pulled down a clean branch and ran yarn install && yarn start and the app worked without problems.

The issue that came up #233 was related to something else, but that issue lead to this PR as well. Michael pulled down and ran the repo and had issues, which based on repo he linked, is why I made the adjustment here. Did you get a chance to look at what he linked in that issue?

[AramayisO]

I'm not sure we need to make cross-env a dependency since it is only used for development. Setting environment variables with cross-env can only work when you run the app using the development server. Once you run yarn build and create a production build, the app is turned into static files and there are no more "environment variables" - all variables get hard-coded in the source code. I think the problem in issue #233 is related to something else. I had that problem once, but then pulled down a clean branch and ran yarn install && yarn start and the app worked without problems.

The issue that came up #233 was related to something else, but that issue lead to this PR as well. Michael pulled down and ran the repo and had issues, which based on repo he linked, is why I made the adjustment here. Did you get a chance to look at what he linked in that issue?

Yes, I looked through the thread linked in #233. It looks like that is the intended behavior and that yarn install comes with --production=false flag to install dev dependencies in production yarnpkg/yarn#2739 (comment).

[AramayisO]

Gonna go ahead and approve to unblock.

[fluturecode]

Gonna go ahead and approve to unblock.

Ok thanks. We can update in the future, and look into this a little more for sure.