Corrected Standard Periodic Kernel #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xponential should contain a 2 and not a 1/2
Some corrections including adapting to current version of pdinv, correcting the expressions of constant, pdf and its gradient, and adding the printing function. After some tests, seems to run as expected, similarly to the Gaussian prior which was already working.
Simple unit test for creating a kernel with Multivariate Gaussian prior over the lengthscales, then performing GP regression.
…s, the exponential should contain a 2 and not a 1/2" This reverts commit 15246e3.
Codecov Report
@@ Coverage Diff @@
## devel #757 +/- ##
==========================================
+ Coverage 54.24% 54.32% +0.08%
==========================================
Files 210 210
Lines 21347 21352 +5
Branches 2883 2884 +1
==========================================
+ Hits 11579 11600 +21
+ Misses 9231 9214 -17
- Partials 537 538 +1 |
|
@lawrennd need your eyes on this one |
|
Closing due to no activity & merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to sources such as http://www.cs.toronto.edu/~duvenaud/cookbook/index.html or the work cited in this code, the exponential in this kernel should contain a 2 and not a 1/2.