When adding SVG picture, handle case where dimensions are SvgUnitType.Percentage #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable AddPicture_adds_svg_picture_no_width_height_tags which passes now. Fixes ShapeCrawler#687
ashahabov
reviewed
May 19, 2024
ashahabov
requested changes
May 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #687 as-written. I still need to test what happens when SVG has also no
viewbox.PR-Codex overview
This PR updates SVG handling in ShapeCrawler. It adds support for SVG images without explicit dimensions and optimizes size calculations.
Detailed summary