Fix custom options #1601
Merged
Fix custom options #1601
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default Value of EnableBiDi in Platform is changed from true to false
Added new incognitoMode property to Web properties with default value of false
Incognito mode flag logic is added for the following browsers: - Chrome - Microsoft Edge - Firefox
IncognitoMode is added to the other Web properties in Test class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
=============================================
+ Coverage 38.12% 53.07% +14.94%
- Complexity 918 1338 +420
=============================================
Files 111 111
Lines 9966 9975 +9
Branches 966 970 +4
=============================================
+ Hits 3800 5294 +1494
+ Misses 5575 4069 -1506
- Partials 591 612 +21 ☔ View full report in Codecov by Sentry. |
MohabMohie
requested changes
Apr 24, 2024
src/main/java/com/shaft/driver/internal/DriverFactory/OptionsManager.java
Outdated
Show resolved
Hide resolved
- Using the Enums to check for the running driver type - Removed unused import of SafariOptions in WebTest class
Revert the change made to EnableBiDi in Platform properties
|
@MohabMohie FYI |
MahmoudElSharkawy
approved these changes
May 19, 2024
MohabMohie
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Enable BiDi property default value is set to false as it was creating conflicts with session related properties like incognitoMode or setting profiles