Remove jdk21 initial support #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
- will not handle all cdp supporting browsers dynamically, firefox is a separate case, and all the rest will follow the manual full-screen mode. Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
|
this is meant to be an ongoing stabilizing PR. we can release after merging it and feeling comfortable with any remaining pipeline failures (real issues now). @MahmoudElSharkawy FYI |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
============================================
+ Coverage 46.57% 47.36% +0.78%
- Complexity 1197 1212 +15
============================================
Files 106 106
Lines 10288 10288
Branches 1070 1071 +1
============================================
+ Hits 4792 4873 +81
+ Misses 4897 4808 -89
- Partials 599 607 +8 ☔ View full report in Codecov by Sentry. |
|
Ubuntu Firefox is throwing a security issue. It's related to gecko driver |
* Update PropertiesHelper.java Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com> * Update pom.xml Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com> --------- Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Signed-off-by: Mohab Mohie <Mohab.MohieElDeen@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the classes to the resources folder, will reuse them at a later stage, this should ensure that the pipeline matches to local tests running under jdk 17 ONLY to facilitate pipeline troubleshooting and fix integrity.