Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A2C and VPG #383

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

A2C and VPG #383

wants to merge 23 commits into from

Conversation

hades-rp2010
Copy link
Member

@hades-rp2010 hades-rp2010 commented Oct 12, 2020

Wrt #375
Mades some changes in discount.py (Really silly mistakes)
Now the 2 agents are training

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #383 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          90       90           
  Lines        3809     3810    +1     
=======================================
+ Hits         3477     3478    +1     
  Misses        332      332           
Impacted Files Coverage Δ
genrl/agents/deep/a2c/a2c.py 93.58% <100.00%> (ø)
genrl/agents/deep/vpg/vpg.py 94.33% <100.00%> (ø)
genrl/utils/discount.py 100.00% <100.00%> (ø)

Copy link
Member

@sampreet-arthi sampreet-arthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, looks like a simple fix. Let's get this merged once #384 resolves the infinite loop thing

@sampreet-arthi sampreet-arthi linked an issue Oct 16, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A2C and VPG do not train
2 participants