This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
update moment.js version and create nodejs example #27
+36,136
−496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated moment.js version in vendor folder - added r.js (require.js) - created nodejs example Minor version bump, Security fix - corrects security advisories 55 & 532 moment/moment#4163 moment/moment#4326 Update package.json and readme.
|
@SeverinDK I thought you might want to review before merging. Also, I thought we might want to change the "master" branch to "main" as per the new standard on github. Let me know your thoughts on both. I will merge after I hear back from you and will rename the branch after you give the ok. I don't want to come in and fully take over. |
|
Nice one @justbill2020 - I will go over this tomorrow and get it merged in. Thank you for the contribution! |
|
@justbill2020 Looks good. You can go ahead with both things. |
SeverinDK
approved these changes
Feb 26, 2021
|
OK, this is now merged. @SeverinDK will you have to tag it as a release and publish to NPM? Also, my permissions don't allow me to rename the branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor version bump, Security fix
moment/moment#4163
moment/moment#4326
Update package.json and readme.