Remove System.Drawing.Imaging references from ArtData #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsYlum-
reviewed
May 8, 2024
| } | ||
|
|
||
| public static Rectangle MeasureBound(Bitmap bmp) | ||
| public static Rectangle MeasureBound(ArtInfo bmp) |
There was a problem hiding this comment.
You may want to rename argument to something else as it's no longer bitmap bmp
AsYlum-
reviewed
May 8, 2024
| { | ||
| Measure(bmp, out var xMin, out var yMin, out var xMax, out var yMax); | ||
|
|
||
| return new Rectangle(xMin, yMin, xMax - xMin, yMax - yMin); | ||
| } | ||
|
|
||
| public static Size MeasureSize(Bitmap bmp) | ||
| public static Size MeasureSize(ArtInfo bmp) |
There was a problem hiding this comment.
You may want to rename argument to something else as it's no longer bitmap bmp
AsYlum-
reviewed
May 8, 2024
| @@ -1221,7 +1221,7 @@ public void SetVisibility(Mobile m, bool? state) | |||
| } | |||
| } | |||
|
|
|||
| public static Bitmap GetBitmap(int itemID) | |||
| public static ArtInfo GetBitmap(int itemID) | |||
There was a problem hiding this comment.
Is it really GetBitmap() at this point? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed reference to System.Drawing.Imaging from ArtData.
Simplified it to only read dimensions and bounds (no access to pixel colors)