Adding exit to trammel despise

[pyro17]

• added exit teleporter tiles to the xml file

PR for Issue #5010

[TrueUO]

https://github.com/ServUO/ServUO/blob/master/Scripts/Items/Internal/DespiseTeleporter.cs

The problem with this, and why it may be missing in the first place, is the exit teleporters need to be DespiseTeleporters to prevent people from leaving the dungeon with their Despise creatures.

[pyro17]

Hmm maybe, but at the same time wouldnt it make more sense to only have 1 Teleport?

the other way would be to use the Evensink on the creatures.

		EventSink.OnEnterRegion += (e) => { if (!(e.NewRegion is DespiseRegion || Map != Map.Trammel)) MoveToWorld(new Point3D(5588, 632, 30), Map.Trammel); };

should be enough to keep them in (as example the entrance location)

would need to unsubscribe on death / delete to clean it up.

That way you would have a way to keep them inside and use 1 teleport system.
And a default way to leave the dungeon

[TrueUO]

I think that makes a lot of sense.

I'm just pointing out the issue, as it stands, with using normal teleporters at the exit

[pyro17]

Was just throwing that in as an alternative.

Question is, what would be the wanted / wished for way

[Lexshmyr]

As it stands, the referenced code has no exit teleporters because the command to add the teleporters references a file that had it's name changed. That seemed to indicate it wasn't working - rather than some of the other pub 57.x->58 deco changes where directories were reorganized.
The file from \Data\TeleportersOld.csv has the data to create those exit teleporters for Despise:
`# Teleporter X,Y,Z,Map,Dest X,Y,Z,Map,Back?

Old Despise

5409,860,52,Trammel,5387,757,-3,Trammel,False
5409,858,52,Trammel,5387,755,-3,Trammel,False
5409,859,52,Trammel,5387,756,-3,Trammel,False`

This file is similarly named to another file that was referenced in /Scripts/Commands/GenTeleporter.cs with the name "teleporters.csv". The file teleporters.csv became the new implementation with TeleporterRegions.xml and the data for Despise exit teleporter was preserved in this new file teleportersOld.csv.

I was not around for that change to deactivate the logic by changing the filename, but can only imagine there was some other issue that was not working related to all of this. It doesn't seem right that simply renaming the file back is the solution.

Is there is a way to research why the changes to the file name was made?
@TrueUO @pyro17

It appears that the exit from Despise was possibly never completed to function. There is no object to serve as the teleporter and thus link the code from DespiseTeleporter.cs.

Maybe Scripts\Services\Dungeons\DespiseRevamped\Setup.cs is the appropriate place to add in creating the teleporter. This would model how the exit teleporter works in Tomb of Kings that allows getting to the ante-chamber. Then remove the teleporterOld.csv file altogether?