Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 58 #4917

Draft
wants to merge 106 commits into
base: master
Choose a base branch
from
Draft

Publish 58 #4917

wants to merge 106 commits into from

Conversation

Voxpire
Copy link
Contributor

@Voxpire Voxpire commented Jan 15, 2021

See individual commit notes for additional details.

Reinstate core support for setting target expansion.
Reinstate core support for checking target expansion for critical network operations.
… projects; this unifies assembly information generation throughout the project.

Updated .editorconfig file with advanced configuration settings that will help maintain user code style and best practices with most IDE's.
Complete core housekeeping operation using "Profile 1" with new .editorconfig settings.
Copy link
Collaborator

@kamronbatman kamronbatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

kevin-10
kevin-10 previously approved these changes Jan 16, 2021
Update collection candidates to use their concurrent counterparts.
Safely de-reference buffers when releasing them in to a buffer pool.
Buffer pools will no longer automatically refill when emptied.
Add ability to push incoming packet data back in to a clients' pending data buffer.
This update allows single packet handlers to handle different client versions.
Always initialize land and static tables at maximum capacity.
@kamronbatman
Copy link
Collaborator

kamronbatman commented Jan 17, 2021

@Vorspire I would probably recommend gating the logging against a DEBUG constant because a malicious user could cause quite a bit of spamming on the console/logs. Thoughts on this?

EDIT: Maybe have the exception logging go to a file, but not to console? 🤔

kevin-10
kevin-10 previously approved these changes Jan 18, 2021
Copy link
Collaborator

@kamronbatman kamronbatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the typo :)

Fix exploit to allow skipping cool-down on fountain of life.
Fix crash caused by negative page ranges in seed box gump.
This update focuses on expanding the Config API.
This update focuses on expanding the Config API.
Removes redundant initialization of VisibleDamageType.
Fix separator for TownCrier save path.
Voxpire and others added 30 commits September 19, 2022 03:59
…s of the HueData color tables.

Adds [HueBrowser command to open the HueDataBrowserGump.
Fixed an issue where long string values could crash the client by overflowing the gump string list.
Added the ability to decorate Type-based properties with a TypeFilterAttribute that constrains the PropertiesGump interaction.
BankerGump switched to BaseGump so BaseGump.SendGump is needed to be called instead
Core and system optimizations.
NPE fix.

Co-authored-by: Voxpire <admin@vita-nex.com>
Critical fix for enum serialization support.
Sphynx should be withdrawing money not giving money to the player.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants