This repository has been archived by the owner on May 3, 2020. It is now read-only.
better meta character cleaning #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We grew frustrated that metacharacters would leave empty newline after report generation so we made some change to the xlst generation function so that : It leaves less unclosed tag (there shouldn't be any really but we never know) It shouldn't leave any empty paragraph tag behind. This has the big advantage that the metacharaters don't leave any unwanted newline after the report has been generated. We also documented which statements to be alone on a newline. This should be more or less the same than with the previous function, but users might have to sightly adjust their report. Thus, this pull request should be ¬ finding:::DREAD_SCORE > 1 ¬ µzzzµ needs to be alone on a newline end of condition (¥) needs to be on a newline end of for-each (∆) needs to be on a newline † DREAD_SCORE > 1 †' needs to be on a newline ƒcodeƒ OUTPUT needs to be on a newline kudos to 4B3l0 for diging into the dark art of word XML
frisch-raphael
changed the title
|
Thanks. The additional (i.e corrected and not misleading) comments are a big win for the xslt code. Also, better whitespace management makes life easier and saves time for an author. However, I agree with your reservations. This needs to go through more testing before I can land. Right now I am not comfortable requiring users to update their templates. I will need to think on this more. Considering allowing the white space management to be optional. |
|
Quick feedback on this : still no problem/bug on our side with this version of the file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We grew frustrated that metacharacters would leave empty newline after report generation so we (and by we, i mean mostly 4B3l0 really) made some changes to the xlst generation function so that :
We also documented which statements need to be alone on a newline. This should be more or less the same than with the previous xlst generation function, but users might have to sightly adjust their report. Thus, we'd understand if this PR wasn't merged, or if it wasn't merged right now ; especially since it modifies such a core function.
Here's the statements that need to be on a newline :
¬ finding:::DREAD_SCORE > 1 ¬ µzzzµneeds to be alone on a newline† DREAD_SCORE > 1 †needs to be on a newlineƒcodeƒ OUTPUTneeds to be on a newlineApart from that, we tested that every metacharacter still works as intended.
kudos to 4B3l0 for diging into the dark art of word XML