LibWeb: Add and use an ad-hoc ReadableStreamDefaultReader::read_all_chunks AO #24179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReadableStreamPipeTo AO requires reading all chunks from a stream. There actually isn't an AO defined to do that, so the "read all bytes" implementation was changed to provide each chunk in a vector in commit 12cfa08. This change makes reading all bytes a bit more uncomfortable in normal use cases, as we now have to manually join the vector we receive. This can also cause churn with huge allocations. So instead, let's just provide an ad-hoc callback to receive each chunk as they arrive.
This reverts commit 12cfa08.
The callback is already specified to take the bytes by value. No need to copy the bytes here.
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #24132 (comment)
These patches were done as part of making fetch use streams to read response bodies. That ultimately has some issues to be worked out, but in the meantime, this affords some cleanup that aligns us back closer to the spec.