Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Add more emoji #24173

Merged
merged 1 commit into from May 11, 2024
Merged

Base: Add more emoji #24173

merged 1 commit into from May 11, 2024

Conversation

Xexxa
Copy link
Collaborator

@Xexxa Xexxa commented Apr 30, 2024

🀽 - U+1F93D PERSON PLAYING WATER POLO
πŸ€½β€β™‚οΈ - U+1F93D U+200D U+2642 MAN PLAYING WATER POLO
πŸ€½β€β™€οΈ - U+1F93D U+200D U+2640 WOMAN PLAYING WATER POLO
🦨 - U+1F9A8 SKUNK

For some reason:
"Error! Emoji entry for U+1F93D_U+200D_U+2642.png not found. Please check emoji-file-list.txt."
Not sure why.

@github-actions github-actions bot added the πŸ‘€ pr-needs-review PR needs review from a maintainer or community member label Apr 30, 2024
@ADKaster
Copy link
Member

ADKaster commented May 1, 2024

Hi @Xexxa , the new emoji are looking cute! In #23643 (specifically, 91cd43a), Tim added a file that lists every single emoji file. This was needed to make sure that we could copy all of the files into the location needed to load the emojis from Ladybird, and to make sure to install only the files we need when installing Ladybird (e.g. for package managers and linux distributions).

So for this patch, you'll need to add a line item for each emoji file in Meta/emoji-file-list.txt

@Xexxa
Copy link
Collaborator Author

Xexxa commented May 11, 2024

Hi @Xexxa , the new emoji are looking cute! In #23643 (specifically, 91cd43a), Tim added a file that lists every single emoji file. This was needed to make sure that we could copy all of the files into the location needed to load the emojis from Ladybird, and to make sure to install only the files we need when installing Ladybird (e.g. for package managers and linux distributions).

So for this patch, you'll need to add a line item for each emoji file in Meta/emoji-file-list.txt

Thanks a lot for the explanation ADKaster, I read the error message("Please check emoji-file-list.txt.") as "Please check emoji-serenity.txt" and was very confused because these are RGI emoji. When expecting one thing and are not focused enough the mind might draw it's own conclusions :-D

🀽 - U+1F93D PERSON PLAYING WATER POLO
πŸ€½β€β™‚οΈ - U+1F93D U+200D U+2642 MAN PLAYING WATER POLO
πŸ€½β€β™€οΈ - U+1F93D U+200D U+2640 WOMAN PLAYING WATER POLO
🦨 - U+1F9A8 SKUNK
@ADKaster ADKaster merged commit a9269af into SerenityOS:master May 11, 2024
12 checks passed
@github-actions github-actions bot removed the πŸ‘€ pr-needs-review PR needs review from a maintainer or community member label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants