Tests/LibELF: Add a test checking initializer ordering; run LibELF tests on Lagom #24170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
DanShaders
force-pushed
the
lagom-dynamic-loader-tests
branch
from
82351c1
to
453d4d4
Compare
ADKaster
reviewed
May 7, 2024
So that we can be sure Serenity's runtime linker performs the same.
DanShaders
force-pushed
the
lagom-dynamic-loader-tests
branch
from
453d4d4
to
36a1618
Compare
ADKaster
approved these changes
May 8, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Daniel noticed in #24067, the tests I added there actually pass on master. Therefore, there's no reason to keep these two commits in it.
Mostly CMake change -> cc @ADKaster