Meta+Documentation+Ports: Move from C++20 to C++23 #24169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
BertalanD
reviewed
Apr 30, 2024
BertalanD
reviewed
Apr 30, 2024
| A host compiler that supports C++20 features is required for building host tools, the newer the better. Tested versions include gcc-12 and clang-15. | ||
| A host compiler that supports C++23 features is required for building host tools, the newer the better. Tested versions include gcc-12 and clang-15. |
There was a problem hiding this comment.
mind the version numbers (anywhere else we mention supported/recommended compiler versions?)
There was a problem hiding this comment.
Those compiler versions support -std=c++2b, which cmake will pass along. Once we start actually using new features, we can revisit the minimums
skyrising
reviewed
Apr 30, 2024
Ports/OpenJDK/patches/0002-make-Build-with-c-20-when-targeting-serenity.patch
Outdated
Show resolved
Hide resolved
Now that oss-fuzz is on a clang commit > the 17.x release candidates, we can start looking at some shiny new features to enable.
|
Drafting until google/oss-fuzz#11874 is merged |
github-actions
bot
removed
the
👀 pr-needs-review
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that oss-fuzz is on a clang commit > the 17.x release candidates, we can start looking at some shiny new features to enable.