LibWeb: Stub out enough IDL interfaces to call BaseAudioContext.createOscillator #24143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
PeriodicWave represents an arbitrary periodic waveform to be used with an OscillatorNode.
An AudioParam is a fundamental building block in WebAudio as it controls the value of an individual parameter of an AudioNode, such as volume.
An AudioNode is the fundamental building block used in 'Audio Contexts'. In our immediate case, the audio node we are working towards implementing is an oscillating source node.
This is a base class of a few different audio nodes, most notably for our immediate needs - OscillatorNode.
This source node generates a periodic wave form.
Which currently will always throw an exception as it is unimplemented under the hood - but this gives all of the plumbing we need in order to create a oscillator node as used in the reduced turnstyle testcase.
shannonbooth
force-pushed
the
infrastructure-for-offline-audio-context-testcase
branch
from
15ed75e
to
6f82bfa
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stub out enough IDL interfaces so that we can actually 'implement' the first first function call in #22902, further work towards #23632
BaseAudioContext.createOscillatorNext steps are to begin actually filling out these implementations enough to actually create the node - and after that is to begin implementing the actual use of it.