Ladybird: Include scroll bar width/height in viewport rect #24103
Conversation
github-actions
bot
added
the
馃憖 pr-needs-review
|
Can you explain what this fixes? Won't this make LibWeb try to paint underneath the scrollbars? |
|
Practically, I've observed this resolve issues where The viewport rect is also used for
|
|
Hmm yeah the Before this patch: With this patch: |
|
It certainly seems wrong that the scroll bar would cover the screen contents. Looking at other browsers, most render the scroll bar as a floating bar - so get away with rendering over the page's contents, but those that have a full scrollbar (like Ladybird) do render as you would expect.
I think the solution is to set 2 viewport rects - one including the scroll bars, and one without. I'll work on making a small reproduction of the |
|
Okay - so it turns out the issue I was having was to do with <style>
body {
margin: 0;
padding: 0;
height: 150vh;
}
#test {
width: 100%;
height: 100vh;
background: url(https://images.placeholders.dev/?width=2200&height=1311&text=WHF!);
background-size: cover !important;
background-position: center !important;
}
</style>
<body>
<div id="test"></div>
</body>
Okay, tangent aside - I'll look into that again another time. Time to start looking into IPC. |
github-actions
bot
removed
the
馃憖 pr-needs-review
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
No description provided.