LibWebView: Invalid URLs no longer replaced with a ":"

[mackfi]

Hi, we are students at the University of Utah working on a Ladybird fix for our final project.

Attempting to navigate to an invalid URL or a non-existent file path (as described in issue #22473) while search is disabled causes the path to be replaced with a colon. To fix this, we added an extra condition to return the URL rather than nothing (which gets interpreted as a colon).

Typing "catdog" into the search bar of a new tab:

Typing "catdog" into the search bar after this change:

[MacDue]

search_engine is now passed to query_public_suffix_list, but it's not actually used there (other than to check if it has a value). Maybe format_search_engine() could just return input URL if the search engine is not available instead?

serenity/Userland/Libraries/LibWebView/URL.cpp

Lines 80 to 81 in a957e68

	if (!search_engine.has_value())
	return {};

[mackfi]

That would seem to be a better solution. I have updated the line inside format_search_engine() that you mentioned, and removed the previous changes. This new change appears to have the exact same effect as the original change.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

[stale]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!