LibWeb: Ensure non-negative inner_bounding_rect dimensions #24032
Conversation
Add checks to prevent negative width and height in inner_bounding_rect within get_outer_box_shadow_configuration. This fixes issues with shadow corner swapping due to incorrect bounding box dimensions. Fixes: SerenityOS#23937
github-actions
bot
added
the
👀 pr-needs-review
Student project from the University of Utah! This formula $1 + (r-1)^3$ is not being used for box shadow corner radius modification, but it should be (see last paragraph in section on [csswg](https://drafts.csswg.org/css-backgrounds/#shadow-shape)). Issue (still may need to be applied for inner shadow boxes): SerenityOS#24033
|
Hi, this is failing a test: https://dev.azure.com/SerenityOS/SerenityOS/_build/results?buildId=46601&view=logs&j=2351e412-c793-598f-27f8-72c4f2d55ba1&t=ee375dfa-6b7d-514a-7789-3948d04c0dd3&l=2278 That's actually to be expected though. Please check that the test looks right, and then run the rebaseline script in |
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
Another student project here!
Add checks to prevent negative width and height in inner_bounding_rect within get_outer_box_shadow_configuration.
This fixes issues with shadow corner swapping
due to incorrect bounding box dimensions.
Fixes part of: #23937