Ports: Update rvvm to 0.6 #23673
Merged
Ports: Update rvvm to 0.6 #23673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
github-actions
bot
removed
the
👀 pr-needs-review
LekKit
force-pushed
the
update-rvvm-port
branch
from
ffb7f10
to
ee600a4
Compare
github-actions
bot
added
the
👀 pr-needs-review
|
CI seems to fail due to upstream LibWeb. |
timschumi
requested changes
Mar 23, 2024
- New upstream stable version is available - Networking is now fully stable and enabled by default - SDL2 backend is now available alongside SDL1, so switch to it - Fixed a name collision of PAGE_SIZE with Serenity headers - Disable threaded IO on Serenity for now - Many other changes and fixes - See https://github.com/LekKit/RVVM/releases/tag/v0.6 for more
LekKit
force-pushed
the
update-rvvm-port
branch
from
ee600a4
to
7f5e79b
Compare
timschumi
approved these changes
Mar 23, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Due to sloppy scheduler/threading behavior on Serenity, threaded IO is disabled in this port for now. Otherwise U-Boot randomly fails to read data from NVMe, or fails to initialize NVMe altogether, along with other IO issues in guests - all due to threaded tasks being randomly delayed for very long.
I am not an expert on how scheduler works in Serenity, so I am unable to fix it yet. This problem was also visible in previous v0.5 version of this port, but back then I thought it's some kind of a temporary problem. Couldn't reproduce this on any other host OS.
Screenshots (Maybe for https://ports.serenityos.net/rvvm):