Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports: Fix libjodycode/jdupes download #23453

Merged
merged 1 commit into from Mar 5, 2024

Conversation

ddorando
Copy link
Contributor

@ddorando ddorando commented Mar 3, 2024

The author unpublished everything on github and moved to codeberg. The different hashes come from the new platform packaging the tarfiles differently than before.

@ddorando ddorando requested a review from timschumi as a code owner March 3, 2024 17:50
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Mar 3, 2024
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this even tested? This does not build, because Codeberg/Forgejo does not append the tag name to the directory name before generating the archive.

The author unpublished everything on github and moved to codeberg.
The different hashes come from the new platform packaging the
tarfiles differently than before.
@ddorando
Copy link
Contributor Author

ddorando commented Mar 4, 2024

Goddamnit. Sorry, don't know what happened here. Fixed it.

@timschumi timschumi merged commit 1986693 into SerenityOS:master Mar 5, 2024
13 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Mar 5, 2024
@ddorando ddorando deleted the jbruchon-port-update branch March 5, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants