You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update pinned browser versions
* Update supported versions for Chrome DevTools
* Update selenium manager version
* Update authors file
* FIX CHANGELOGS BEFORE MERGING!
Update versions and change logs to release Selenium 4.21.0
* [create-pull-request] automated change
* [js] Running format script
* [java] Enabling some Chrome tests work with BiDi
* [dotnet] Using CDP 124 in the meantime
* [dotnet] Excluding Edge until CDP 125 is available for it
* [java] Enabling bidi tests for Chrome
* [rb] Enabling bidi tests
* [bidi] Remove root ownership parameter due to update in BiDi spec
* Updating changelogs
---------
Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@gmail.com>
Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
4, because the PR involves multiple changes across various files and languages, including updates to dependencies, addition of new features, and removal of deprecated features. The complexity is increased due to the need to ensure compatibility and correct functionality across different components.
🧪 Relevant tests
No
⚡ Possible issues
Possible Bug: The PR introduces changes to version numbers and dependencies which might not be fully compatible or could lead to unexpected behaviors if not properly tested.
Performance Concern: Extensive changes in core functionalities, such as updates to the DevTools protocol versions, could impact performance if not optimized and tested thoroughly.
Verify and ensure the correctness of SHA256 checksums for software dependencies
Verify the new SHA256 checksums for the updated URLs to ensure they are correct and have not been tampered with. This is crucial for maintaining the integrity and security of the software dependencies.
Why: This is a crucial security suggestion ensuring the integrity of the software dependencies by verifying SHA256 checksums, especially when URLs are updated.
10
Possible issue
Ensure proper initialization of v125Target with required dependencies
Ensure that the v125Target constructor is properly initialized with necessary parameters or resources.
-target = new v125Target();+target = new v125Target(devtools);
Suggestion importance[1-10]: 8
Why: Ensuring that v125Target is properly initialized with necessary parameters is crucial for the correct functioning of the class. This addresses a potential major issue in resource initialization.
8
Add null checks to constructor parameters to ensure stability
Add null checks in the constructor for network and fetch parameters to prevent null reference exceptions when methods on these objects are called.
public V125Network(NetworkAdapter network, FetchAdapter fetch)
{
- this.network = network;- this.fetch = fetch;+ this.network = network ?? throw new ArgumentNullException(nameof(network));+ this.fetch = fetch ?? throw new ArgumentNullException(nameof(fetch));
}
Suggestion importance[1-10]: 8
Why: Adding null checks in the constructor for network and fetch is a valid suggestion to prevent null reference exceptions, enhancing the robustness of the code.
8
Review org.redisson:redisson update for potential breaking changes
Review the necessity of updating org.redisson:redisson:3.30.0 as major version updates might introduce breaking changes that could affect the existing functionalities.
-"org.redisson:redisson:3.30.0"+"org.redisson:redisson:3.30.0" # Review for potential breaking changes
Suggestion importance[1-10]: 3
Why: The suggestion is generally good practice when updating major versions, but it lacks context on whether the version update actually introduces breaking changes, making it a precautionary suggestion rather than a critical one.
3
Enhancement
Improve error handling by using a specific exception type in the lambda function
Consider using a more specific exception type in the lambda function for better error handling and debugging.
-id -> new org.openqa.selenium.devtools.v125.target.model.TargetID(id.toString())+id -> {+ try {+ return new org.openqa.selenium.devtools.v125.target.model.TargetID(id.toString());+ } catch (IllegalArgumentException e) {+ throw new CustomException("Invalid TargetID format", e);+ }+}
Suggestion importance[1-10]: 7
Why: Adding specific exception handling in the lambda function can significantly improve the robustness and debuggability of the code. This is a good enhancement, especially for error-prone operations.
7
Improve the clarity and detail of the test description to better reflect its purpose
Ensure that the test description accurately reflects the test's purpose and conditions. The description 'does not close BiDi session if at least one window is opened' should be clear and possibly include more details if the test's logic is complex or not immediately obvious from the description.
-it 'does not close BiDi session if at least one window is opened',+it 'ensures BiDi session remains open if at least one browser window is still open',
Suggestion importance[1-10]: 3
Why: The suggestion to enhance the test description is valid but not critical. The existing description is adequate, though the suggested improvement could help clarify the test's intent.
3
Best practice
Use ConfigureAwait(false) to avoid capturing the synchronization context
Use ConfigureAwait(false) on all awaited operations within ContinueWithAuth to avoid deadlocks and to not capture the synchronization context unnecessarily.
Why: The suggestion to use ConfigureAwait(false) on all awaited operations within ContinueWithAuth is correct and follows best practices for asynchronous programming in C#, helping to avoid potential deadlocks in non-UI thread contexts.
7
Replace a magic value with a constant for clarity and ease of updates
Use a constant for the 'flatten' parameter to improve code readability and maintainability.
-"flatten", true+private static final boolean FLATTEN = true;+...+"flatten", FLATTEN
Suggestion importance[1-10]: 6
Why: Using a constant for the 'flatten' parameter enhances code readability and maintainability. It's a good practice, though not critical.
6
Use detailed semantic versioning for clarity and better release management
Update the version string format to include a more detailed semantic versioning, especially if this is a stable release. Consider using a format like '4.21.0-stable' to differentiate from development or nightly builds.
Why: The suggestion to use '4.21.0-stable' instead of '4.21.0' is a minor enhancement and not necessary unless there is a specific need to distinguish between stable and other types of builds in this context. The PR seems to standardize versioning across multiple files without specifying build types.
2
Possible bug
Ensure locator parameter is correctly typed to prevent runtime errors
Add validation to check if locator is an instance of Locator in the locateNodes method to ensure type safety and clearer error handling.
async locateNodes(
locator,
maxNodeCount = undefined,
sandbox = undefined,
serializationOptions = undefined,
startNodes = undefined,
) {
+ if (!(locator instanceof Locator)) {+ throw new Error('locator must be an instance of Locator');+ }
...
}
Suggestion importance[1-10]: 7
Why: Adding a type check for the locator parameter in the locateNodes method is a good practice to ensure that the method is called with the correct type, preventing runtime errors and improving code reliability.
7
Performance
Optimize lambda expression to method reference for cleaner and more efficient code
Use a method reference instead of a lambda for better performance and readability when applying a function.
-input -> {- org.openqa.selenium.devtools.v125.target.model.SessionID id = mapper.apply(input);- return new SessionID(id.toString());-}+mapper.andThen(id -> new SessionID(id.toString()))::apply
Suggestion importance[1-10]: 5
Why: Using method references can indeed improve performance and readability. However, the impact might be minimal, making this a moderate improvement.
5
Compatibility
Verify compatibility of org.mockito:mockito-core with other testing frameworks
Ensure that the newly added org.mockito:mockito-core:5.12.0 version is compatible with other testing frameworks used in the project to avoid any runtime issues.
-"org.mockito:mockito-core:5.12.0"+"org.mockito:mockito-core:5.12.0" # Ensure compatibility with other testing frameworks
Suggestion importance[1-10]: 3
Why: The suggestion is valid in terms of ensuring compatibility, but it lacks specific details on incompatibilities or issues with the version update, making it a minor improvement suggestion.
Failed test name: Selenium::WebDriver::Window can minimize the window
Failure summary:
The action failed due to a test failure in the //rb/spec/integration/selenium/webdriver:window-safari-remote test suite. Specifically, the test Selenium::WebDriver::Window can minimize the window failed repeatedly across multiple attempts. The failure was caused by a Selenium::WebDriver::Error::TimeoutError, indicating that the expected condition to verify if the document was hidden did not occur within the specified timeout of 10 seconds. This suggests either a performance issue or an incorrect expectation in the test scenario.
Relevant error logs:
1: ##[group]Operating System2: macOS
...
754: �[1mexternal/protobuf~/src/google/protobuf/generated_message_tctable_lite.cc:347:14: �[0m�[0;1;35mwarning: �[0m�[1munused function 'Offset' [-Wunused-function]�[0m755: inline void* Offset(void* base, uint32_t offset) {756: �[0;1;32m ^757: �[0m1 warning generated.758: �[32mINFO: �[0mFrom Linking external/protobuf~/libprotobuf_lite.a [for tool]:759: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protobuf_lite/io_win32.o has no symbols760: �[32m[1,764 / 3,075]�[0m Executing genrule //common/devtools/chromium/v125:browser_protocol; 2s disk-cache, darwin-sandbox ... (4 actions, 3 running)761: �[32mINFO: �[0mFrom Linking external/protobuf~/libprotobuf.a [for tool]:762: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protobuf/error_listener.o has no symbols
...
908: �[32m[2,916 / 3,075]�[0m MergeJars java/src/org/openqa/selenium/manager/manager-project.jar; 0s disk-cache, darwin-sandbox ... (2 actions running)909: �[32m[2,921 / 3,075]�[0m MergeJars java/src/org/openqa/selenium/manager/manager-project.jar; 1s disk-cache, darwin-sandbox ... (4 actions running)910: �[32m[2,937 / 3,075]�[0m MergeJars java/src/org/openqa/selenium/manager/manager-project.jar; 2s disk-cache, darwin-sandbox ... (4 actions running)911: �[32m[2,944 / 3,075]�[0m Action java/src/org/openqa/selenium/manager/manager-module-module-info.jar; 0s disk-cache, darwin-sandbox912: �[32m[2,945 / 3,075]�[0m Action java/src/org/openqa/selenium/manager/libmanager-module.jar; 0s disk-cache, darwin-sandbox913: �[32m[2,946 / 3,075]�[0m [Prepa] Extracting interface for jar bazel-out/darwin_x86_64-fastbuild/bin/java/src/org/openqa/selenium/manager/libmanager-module.jar914: �[32m[2,956 / 3,075]�[0m Building java/src/org/openqa/selenium/remote/libapi-class.jar (66 source files); 1s disk-cache, multiplex-worker915: �[32mINFO: �[0mFrom Building java/src/org/openqa/selenium/remote/libapi-class.jar (66 source files):916: java/src/org/openqa/selenium/remote/ErrorHandler.java:46: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal917: private final ErrorCodes errorCodes;918: ^919: java/src/org/openqa/selenium/remote/ErrorHandler.java:60: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal920: this.errorCodes = new ErrorCodes();921: ^922: java/src/org/openqa/selenium/remote/ErrorHandler.java:68: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal923: public ErrorHandler(ErrorCodes codes, boolean includeServerErrors) {924: ^925: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal926: ErrorCodes errorCodes = new ErrorCodes();927: ^928: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal929: ErrorCodes errorCodes = new ErrorCodes();930: ^931: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:181: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal932: response.setStatus(ErrorCodes.SUCCESS);933: ^934: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:182: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal935: response.setState(ErrorCodes.SUCCESS_STRING);936: ^937: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:53: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal938: new ErrorCodes().toStatus((String) rawError, Optional.of(tuple.getStatusCode())));939: ^940: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:56: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal941: new ErrorCodes().getExceptionType((String) rawError);942: ^943: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal944: private final ErrorCodes errorCodes = new ErrorCodes();945: ^946: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal947: private final ErrorCodes errorCodes = new ErrorCodes();948: ^949: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal950: int status = response.getStatus() == ErrorCodes.SUCCESS ? HTTP_OK : HTTP_INTERNAL_ERROR;951: ^952: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:101: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal953: response.setStatus(ErrorCodes.UNKNOWN_COMMAND);954: ^955: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:103: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal956: response.setStatus(ErrorCodes.UNHANDLED_ERROR);957: ^958: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:124: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal959: response.setStatus(ErrorCodes.SUCCESS);960: ^961: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:125: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal962: response.setState(errorCodes.toState(ErrorCodes.SUCCESS));963: ^964: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:131: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal965: response.setState(errorCodes.toState(ErrorCodes.SUCCESS));966: ^967: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal968: private final ErrorCodes errorCodes = new ErrorCodes();969: ^970: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal971: private final ErrorCodes errorCodes = new ErrorCodes();972: ^973: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:93: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal974: response.setStatus(ErrorCodes.UNKNOWN_COMMAND);975: ^976: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:98: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal977: response.setStatus(ErrorCodes.UNHANDLED_ERROR);978: ^979: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:145: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal980: response.setStatus(ErrorCodes.SUCCESS);
...
1016: �[32m[3,076 / 3,077]�[0m 1 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:driver-safari-remote; 44s local, disk-cache1017: �[32m[3,077 / 3,078]�[0m 2 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 1s disk-cache1018: �[32m[3,077 / 3,078]�[0m 2 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 0s local, disk-cache1019: �[32m[3,077 / 3,078]�[0m 2 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 62s local, disk-cache1020: �[32m[3,078 / 3,079]�[0m 3 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 0s disk-cache1021: �[32m[3,078 / 3,079]�[0m 3 / 24 tests;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote1022: �[32m[3,078 / 3,079]�[0m 3 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 1s local, disk-cache1023: �[32m[3,078 / 3,079]�[0m 3 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 20s local, disk-cache1024: �[32m[3,079 / 3,080]�[0m 4 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 1s disk-cache1025: �[32m[3,079 / 3,080]�[0m 4 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 0s local, disk-cache1026: �[32m[3,079 / 3,080]�[0m 4 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 16s local, disk-cache
...
1084: �[32m[3,095 / 3,096]�[0m 20 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 39s local, disk-cache1085: �[31m�[1mFAIL: �[0m//rb/spec/integration/selenium/webdriver:window-safari-remote (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test_attempts/attempt_1.log)1086: �[32m[3,095 / 3,096]�[0m 20 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 41s local, disk-cache1087: �[32m[3,095 / 3,096]�[0m 20 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 78s local, disk-cache1088: �[31m�[1mFAIL: �[0m//rb/spec/integration/selenium/webdriver:window-safari-remote (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test_attempts/attempt_2.log)1089: �[32m[3,095 / 3,096]�[0m 20 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 80s local, disk-cache1090: �[32m[3,095 / 3,096]�[0m 20 / 24 tests;�[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 120s local, disk-cache1091: �[31m�[1mFAIL: �[0m//rb/spec/integration/selenium/webdriver:window-safari-remote (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test.log)1092: �[31m�[1mFAILED: �[0m//rb/spec/integration/selenium/webdriver:window-safari-remote (Summary)
...
1109: gets the size of the current window1110: sets the size of the current window1111: gets the position of the current window1112: sets the position of the current window1113: gets the rect of the current window1114: sets the rect of the current window1115: can maximize the current window1116: can make window full screen1117: can minimize the window (FAILED - 1)1118: Failures:1119: 1) Selenium::WebDriver::Window can minimize the window1120: Failure/Error:1121: expect {1122: wait.until { driver.execute_script('return document.hidden;') }1123: }.not_to raise_error1124: expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 10 seconds> with backtrace:1125: # ./rb/lib/selenium/webdriver/common/wait.rb:73:in `until'1126: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:131:in `block (3 levels) in <module:WebDriver>'1127: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:130:in `block (2 levels) in <module:WebDriver>'1128: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:130:in `block (2 levels) in <module:WebDriver>'1129: Finished in 36.84 seconds (files took 0.25852 seconds to load)1130: 9 examples, 1 failure1131: Failed examples:
...
1146: gets the size of the current window1147: sets the size of the current window1148: gets the position of the current window1149: sets the position of the current window1150: gets the rect of the current window1151: sets the rect of the current window1152: can maximize the current window1153: can make window full screen1154: can minimize the window (FAILED - 1)1155: Failures:1156: 1) Selenium::WebDriver::Window can minimize the window1157: Failure/Error:1158: expect {1159: wait.until { driver.execute_script('return document.hidden;') }1160: }.not_to raise_error1161: expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 10 seconds> with backtrace:1162: # ./rb/lib/selenium/webdriver/common/wait.rb:73:in `until'1163: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:131:in `block (3 levels) in <module:WebDriver>'1164: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:130:in `block (2 levels) in <module:WebDriver>'1165: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:130:in `block (2 levels) in <module:WebDriver>'1166: Finished in 36.55 seconds (files took 0.2595 seconds to load)1167: 9 examples, 1 failure1168: Failed examples:
...
1183: gets the size of the current window1184: sets the size of the current window1185: gets the position of the current window1186: sets the position of the current window1187: gets the rect of the current window1188: sets the rect of the current window1189: can maximize the current window1190: can make window full screen1191: can minimize the window (FAILED - 1)1192: Failures:1193: 1) Selenium::WebDriver::Window can minimize the window1194: Failure/Error:1195: expect {1196: wait.until { driver.execute_script('return document.hidden;') }1197: }.not_to raise_error1198: expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 10 seconds> with backtrace:1199: # ./rb/lib/selenium/webdriver/common/wait.rb:73:in `until'1200: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:131:in `block (3 levels) in <module:WebDriver>'1201: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:130:in `block (2 levels) in <module:WebDriver>'1202: # ./rb/spec/integration/selenium/webdriver/window_spec.rb:130:in `block (2 levels) in <module:WebDriver>'1203: Finished in 39.16 seconds (files took 0.2642 seconds to load)1204: 9 examples, 1 failure1205: Failed examples:1206: rspec ./rb/spec/integration/selenium/webdriver/window_spec.rb:127 # Selenium::WebDriver::Window can minimize the window1207: ================================================================================1208: �[32m[3,096 / 3,097]�[0m 21 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:guard-safari-remote; 1s disk-cache1209: �[32m[3,096 / 3,097]�[0m 21 / 24 tests, �[31m�[1m1 failed�[0m;�[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:guard-safari-remote1210: �[32m[3,096 / 3,097]�[0m 21 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:guard-safari-remote; 1s local, disk-cache1211: �[32m[3,096 / 3,097]�[0m 21 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:guard-safari-remote; 17s local, disk-cache1212: �[32m[3,097 / 3,098]�[0m 22 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-safari-remote; 1s disk-cache1213: �[32m[3,097 / 3,098]�[0m 22 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-safari-remote; 0s local, disk-cache1214: �[32m[3,097 / 3,098]�[0m 22 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:devtools-safari-remote; 252s local, disk-cache1215: �[32m[3,098 / 3,099]�[0m 23 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:navigation-safari-remote; 1s disk-cache1216: �[32m[3,098 / 3,099]�[0m 23 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:navigation-safari-remote; 0s local, disk-cache1217: �[32m[3,098 / 3,099]�[0m 23 / 24 tests, �[31m�[1m1 failed�[0m;�[0m Testing //rb/spec/integration/selenium/webdriver:navigation-safari-remote; 17s local, disk-cache1218: �[32mINFO: �[0mFound 24 test targets...1219: �[32mINFO: �[0mElapsed time: 1853.151s, Critical Path: 338.30s1220: �[32mINFO: �[0m2869 processes: 1413 disk cache hit, 1165 internal, 173 darwin-sandbox, 52 local, 66 worker.1221: �[32mINFO: �[0mBuild completed, 1 test FAILED, 2869 total actions1222: //rb/spec/integration/selenium/webdriver:action_builder-safari-remote �[0m�[32mPASSED�[0m in 104.1s1223: //rb/spec/integration/selenium/webdriver:bidi-safari-remote �[0m�[32mPASSED�[0m in 108.0s1224: //rb/spec/integration/selenium/webdriver:devtools-safari-remote �[0m�[32mPASSED�[0m in 252.7s1225: //rb/spec/integration/selenium/webdriver:driver-safari-remote �[0m�[32mPASSED�[0m in 44.0s1226: //rb/spec/integration/selenium/webdriver:element-safari-remote �[0m�[32mPASSED�[0m in 53.9s1227: //rb/spec/integration/selenium/webdriver:error-safari-remote �[0m�[32mPASSED�[0m in 16.3s
...
1237: //rb/spec/integration/selenium/webdriver:timeout-safari-remote �[0m�[32mPASSED�[0m in 20.8s1238: //rb/spec/integration/selenium/webdriver:virtual_authenticator-safari-remote �[0m�[32mPASSED�[0m in 16.3s1239: //rb/spec/integration/selenium/webdriver:zipper-safari-remote �[0m�[32mPASSED�[0m in 17.2s1240: //rb/spec/integration/selenium/webdriver/bidi:browsing_context-safari-remote �[0m�[32mPASSED�[0m in 235.9s1241: //rb/spec/integration/selenium/webdriver/bidi:log_inspector-safari-remote �[0m�[32mPASSED�[0m in 276.6s1242: //rb/spec/integration/selenium/webdriver/remote:driver-safari-remote �[0m�[32mPASSED�[0m in 16.0s1243: //rb/spec/integration/selenium/webdriver/remote:element-safari-remote �[0m�[32mPASSED�[0m in 16.7s1244: //rb/spec/integration/selenium/webdriver/safari:driver-safari-remote �[0m�[32mPASSED�[0m in 15.3s1245: //rb/spec/integration/selenium/webdriver:window-safari-remote �[0m�[31m�[1mFAILED�[0m in 3 out of 3 in 41.4s1246: Stats over 3 runs: max = 41.4s, min = 39.0s, avg = 39.9s, dev = 1.1s1247: /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test.log1248: /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test_attempts/attempt_1.log1249: /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test_attempts/attempt_2.log1250: Executed 24 out of 24 tests: 23 tests pass and �[0m�[31m�[1m1 fails locally�[0m.1251: There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.1252: �[0m1253: ##[error]Process completed with exit code 3.
✨ CI feedback usage guide:
The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:
Failed stage
Failed test name
Failure summary
Relevant error logs
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.
Configuration options
enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.
See more information about the checks tool in the docs.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
enhancement, bug_fix
Description
ownershipparameter from Node.js BrowsingContext methods.Changes walkthrough 📝
14 files
v125Target.java
Update Java DevTools v125Target for Chrome 125java/src/org/openqa/selenium/devtools/v125/v125Target.java
v125Network.java
Refactor Java DevTools v125Network for Chrome 125java/src/org/openqa/selenium/devtools/v125/v125Network.java
v125Events.java
Update Java DevTools v125Events for new event handling in Chrome 125java/src/org/openqa/selenium/devtools/v125/v125Events.java
v125Domains.java
Refactor Java DevTools v125Domains for Chrome 125java/src/org/openqa/selenium/devtools/v125/v125Domains.java
v125Javascript.java
Update Java DevTools v125Javascript for Chrome 125java/src/org/openqa/selenium/devtools/v125/v125Javascript.java
v125Log.java
Update Java DevTools v125Log for Chrome 125java/src/org/openqa/selenium/devtools/v125/v125Log.java
v125CdpInfo.java
Update Java DevTools v125CdpInfo for Chrome 125java/src/org/openqa/selenium/devtools/v125/v125CdpInfo.java
V125Domains.cs
Update .NET WebDriver DevTools V125Domains for Chrome 125dotnet/src/webdriver/DevTools/v125/V125Domains.cs
V125Network.cs
Update .NET WebDriver DevTools V125Network for Chrome 125dotnet/src/webdriver/DevTools/v125/V125Network.cs
V125JavaScript.cs
Update .NET WebDriver DevTools V125JavaScript for Chrome 125dotnet/src/webdriver/DevTools/v125/V125JavaScript.cs
V125JavaScript
V125Target.cs
Update .NET WebDriver DevTools V125Target for Chrome 125dotnet/src/webdriver/DevTools/v125/V125Target.cs
V125Log.cs
Update .NET WebDriver DevTools V125Log for Chrome 125dotnet/src/webdriver/DevTools/v125/V125Log.cs
browsingContext.js
Remove ownership parameter from BrowsingContext methods in Node.jsjavascript/node/selenium-webdriver/bidi/browsingContext.js
ownershipparameter fromlocateNodesandlocateNodemethods
js_protocol.pdl
Add new protocol definitions for Chrome DevTools v125common/devtools/chromium/v125/js_protocol.pdl
1 files
CHANGELOG
Update Java CHANGELOG for version 4.21.0java/CHANGELOG