-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Window Timeout Field in the Command Editor, for Commands Marked as Opening a Window #1830
Conversation
…e flagged as opening new windows
PR Description updated to latest commit (adcd7c4)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging this now and will increment later tonight.
I absolutely appreciate this, thank you. There may be stuff to do here in the side-runtime to connect this fully. Would you like me to examine whats going on there?
I don't mind taking a look at it and seeing if anything needs connecting up - I think Intellisense might have pointed one or two things out so I'll start there |
🪨 ⭐ |
@AlexGarrity - Just wanted to let you know we cut beta v12 this morning, which has your window timeout changes. Nice work there again! |
@toddtarsi Happy to hear it. Here's hoping that someone else finds it as useful as I have so far. I've had a look through side-runtime and -api but it looks to be pretty plug-and-play - the framework was there already, just not the UI. If you have any code areas in mind, however, then I'd be happy to take a look at them? |
That's wonderful! I actually had no idea about if that field was getting picked off correctly honestly, nice job bringing that back fully then! 🥂 |
User description
Description
Adds a text field to the command editor that allows you to specify the window timeout if a command is flagged as opening a window.
Motivation and Context
(Copied from Issue #1829)
I use Selenium IDE to test a website which occasionally has quite long page load times. As a consequence of this, the default 2 second timeout on opening a window is too short, and frequently causes tests to fail when they're actually fine. It's possible to change this behaviour by editing the .side file itself, but it's not exactly the cleanest way of doing it.
Types of changes
Checklist
PR Type
Enhancement
Description
Changes walkthrough 📝
index.ts
Add English Localization for Window Timeout
packages/selenium-ide/src/browser/I18N/en/index.ts
support the new window timeout functionality.
index.ts
Add Chinese Localization for Window Timeout
packages/selenium-ide/src/browser/I18N/zh/index.ts
Chinese to support the new window timeout functionality.
TestCommandEditor.tsx
Implement Window Timeout Field in Command Editor
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/TestCommandEditor.tsx
opens a new window.
types.ts
Update Command Field Types to Include Window Timeout
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/types.ts
as a possible field name.