Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send null values instead of -1 values #65

Merged
merged 4 commits into from Dec 30, 2022
Merged

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 29, 2022

Send null values instead of -1 values, which avoids recording -1 values in FlexMeasures, while still correctly spacing the data sent.

This is possible since FlexMeasures/flexmeasures#549.

@ArdJonker, can you verify that this works as expected in production?

(In case you are wondering, the Python None values are changed into JavaScript null values in the call to requests.post(), which turns the sent message - a dict - into a JSON string.)

…lexMeasures while still correctly spacing the data sent
@Flix6x Flix6x self-assigned this Dec 29, 2022
Copy link
Collaborator

@ArdJonker ArdJonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@ArdJonker
Copy link
Collaborator

Ohh, forgot, also the readme has changed as apps.yaml and secrets.yaml change aswell..

@Flix6x Flix6x merged commit 948e9ab into main Dec 30, 2022
@Flix6x Flix6x deleted the sending-null-values-is-allowed branch December 30, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants