Fix incompatible query filters #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of querying with the most_recent_beliefs_only and beliefs_after (and/or beliefs_before) filters on sensors with unsuitable knowledge horizon functions, and use belief_utils.select_most_recent_belief on the query results instead.
Flix6x
added
bug
2 tasks
nhoening
approved these changes
Nov 6, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements one of the fixes suggested in #97.
Avoid using the
most_recent_beliefs_onlysubquery in the special case of querying with themost_recent_beliefs_onlyandbeliefs_after(and/orbeliefs_before) filters on sensors with unsuitable knowledge horizon functions, and usebelief_utils.select_most_recent_beliefon the query results instead.