This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Fix docker build and run stages #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using RUN is required to exit non-zero during both a `docker build` command with `--target` stage not defined, and with a `docker run` that uses an already-built image (See `Makefile` and `Dockerfile`)
Using RUN is required to exit non-zero during both a `docker build` command with `--target` stage not defined, and with a `docker run` that uses an already-built image (See `Makefile` and `Dockerfile`) Also, move to a cleaner approach to sharing information from arguments across a multi-stage docker build, based on moby/moby#37345 (comment)
Update the reports/ folder via `make report`
JonZeolla
added a commit
that referenced
this pull request
Jan 2, 2020
* fix(docker): Ensure docker run and build exit on stage failures Using RUN is required to exit non-zero during both a `docker build` command with `--target` stage not defined, and with a `docker run` that uses an already-built image (See `Makefile` and `Dockerfile`) Also, move to a cleaner approach to sharing information from arguments across a multi-stage docker build, based on moby/moby#37345 (comment)
JonZeolla
added a commit
that referenced
this pull request
Jan 2, 2020
Using RUN is required to exit non-zero during both a `docker build` command with `--target` stage not defined, and with a `docker run` that uses an already-built image (See `Makefile` and `Dockerfile`) Also, move to a cleaner approach to sharing information from arguments across a multi-stage docker build, based on moby/moby#37345 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
Using RUN is required to exit non-zero during both a
docker buildcommand with
--targetstage not defined, and with adocker runthatuses an already-built image (See
MakefileandDockerfile)Also, move to a cleaner approach to sharing information from arguments
across a multi-stage docker build, based on
moby/moby#37345 (comment)
Pull Request Checklist
Thank you for submitting a contribution to
easy_sast!In order to streamline the review of your contribution we ask that you review and comply with the below requirements:
make buildcompletes successfullymake reportmaster