Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align functions with camelcase in #12 #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

i-walker
Copy link

  • There are 3 broken tests, which I don't know how to fix, or identify from the compiler message
Screenshot 2024-01-29 at 02 13 08
  • I wanted to suggest functions like mList~> mlist to be manuallist instead since abbreviations are also not recommended
- conciseness is valued, but avoid abbreviation ([indexin](https://docs.julialang.org/en/v1/base/collections/#Base.indexin) rather than indxin) as it becomes difficult to remember whether and how particular words are abbreviated.

@Seelengrab
Copy link
Owner

Seelengrab commented Jan 29, 2024

There are 3 broken tests, which I don't know how to fix, or identify from the compiler message

The known-broken tests relate to shrinking of BigFloat & BigInt and to preserving invariants when mapping over IntegratedBoundedRec. They should be marked broken in the testsuite. For the former two, it's simply not implemented because generating & shrinking their objects can easily run out of memory, even with the kind of lazy generation we're doing here. For the latter, I haven't found a solution yet. Fixing these is not a priority :)

I wanted to suggest functions like mList~> mlist to be manuallist instead since abbreviations are also not recommended

The whole Manual business is a bit ugly, yes. I wanted to do a bigger refactor at some point of that entire part of the package, but have since recognized that the approach taken in this package is a bit inferior to others. I'm not sure if I'll ever get around to changing that in this package and since this is very much internal, it's fine leaving it as-is.

--

Other than that, thank you for the PR! I'll leave it open for now and merge it when/if I slate a new breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants