Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor: update to truffle ^5 and solidity ^0.5 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kizzx2
Copy link

@kizzx2 kizzx2 commented Feb 26, 2019

Description

refactor: update to truffle ^5 and solidity ^0.5

What kind of change does this PR introduce?

Please check the boxes that the PR fulfills:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes below. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

What is the new behavior?

(Please define and describe any new functionality below. Clarify if this is a feature change)

Submission Checklist:

  • Proposed code follows the style guide of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have commented my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Any Additional Information:

Add data location specification to contracts
@satyamakgec
Copy link
Collaborator

@kizzx2 Thanks for showing interest. Test cases are failing could you please fix the test cases so I can review it to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants