Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for usage of skip while using DerivePartialModel (analagous to FromQueryResult) #2167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jreppnow
Copy link

@jreppnow jreppnow commented Mar 21, 2024

PR Info

New Features

  • allow for usage of skip when deriving PartialModelTrait, analogous to FromQueryResult
  • adjust the related error messages accordingly

Changes

  • fixed some typos in the related error messages/types

@jreppnow jreppnow changed the title Feat/reppnj/partial model skip feat: allow for usage of skip while using DerivePartialModel (analagous to FromQueryResult) Mar 21, 2024
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jreppnow, thanks for contributing!! I have some suggested changes!
Please check if that make sense to you :)

pol-inc/sea-orm@feat/reppnj/partial-model-skip...billy1624:pr/2167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants