Allow localized product details #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apepper
reviewed
Apr 23, 2024
apepper
approved these changes
Apr 30, 2024
Comment on lines
-7
to
-23
| cartAddedMessage: { | ||
| title: 'Confirmation message after adding', | ||
| }, | ||
| cartAddLabel: { | ||
| title: 'Add-button label', | ||
| }, | ||
| cartRemovedMessage: { | ||
| title: 'Confirmation message after removing', | ||
| }, | ||
| cartRemoveLabel: { | ||
| title: 'Remove-button label', | ||
| }, | ||
| cartUnvailableMessage: { | ||
| title: 'Add-button tooltip if not logged in', | ||
| description: | ||
| 'The placeholder __product__ is available for all labels and messages.', | ||
| }, |
There was a problem hiding this comment.
Please provide a working copy where you cleared these values.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final implementation with hardcoded de/en localizers. No working copy needed.