Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "_id" attributes to many data classes #251

Merged
merged 1 commit into from May 6, 2024
Merged

Add "_id" attributes to many data classes #251

merged 1 commit into from May 6, 2024

Conversation

apepper
Copy link
Contributor

@apepper apepper commented Jan 23, 2024

No description provided.

@apepper
Copy link
Contributor Author

apepper commented Mar 19, 2024

FYI: Needs Scrivito 1.41.0 (not yet released).

@apepper apepper changed the title Add "_id" attributes to Order, Quote, Ticket(Message) & User Add "_id" attributes to many data classes Apr 23, 2024
@apepper apepper requested a review from dcsaszar April 23, 2024 09:42
@dcsaszar dcsaszar self-assigned this Apr 23, 2024
Copy link
Contributor

@dcsaszar dcsaszar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. My only question is

  • Which criteria do we use to decide if an ID should be part of the editing config or not?

I'd like to avoid overloading the UI with details editors may never need.

@apepper
Copy link
Contributor Author

apepper commented Apr 23, 2024

Which criteria do we use to decide if an ID should be part of the editing config or not?

Roughly: If one could want to filter for this attribute (e.g. look for the user of the current ticket). But since this can't be completely known for all cases I would say: Add _id Attributes for all data classes, except for n:m relation ship data classes.

@apepper apepper merged commit e7447c6 into main May 6, 2024
5 checks passed
@apepper apepper deleted the id_attribute branch May 6, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants