Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook and update readme #16

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Conversation

jamespaulmuir
Copy link
Contributor

Making sure yarn.lock has correct versions for storybook to able to build components and update README to include dev steps to run storybook.

Copy link
Contributor

@georgialoper georgialoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up needing to run yarn add vue-loader@next -D (following this SO answer) to get storybook to compile without the pictured errors even after pulling this updated yarn.lock file. I removed vue-loader from package.json and tried to reinstall it, but didn't get anything in my git diff. I have no idea what's up with that, but thought I'd document this in case anyone else experiences issues running storybook. Thanks for updating these!

Screen Shot 2021-06-02 at 9 23 53 AM

@georgialoper
Copy link
Contributor

@jamespaulmuir just pushed this commit based on suggestions in this storybook issue that seems to have solved my issue running yarn run storybook outlined above and allows me to run yarn run build-storybook successfully as well. Seems like transitive dependencies of storybook were using vue 2 versions of vue-loader, this forces them to use the vue3 version.

@jamespaulmuir jamespaulmuir merged commit dc6daac into master Jun 4, 2021
@jamespaulmuir jamespaulmuir deleted the fix-storybook-update-readme branch June 18, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants