Add more journal/syslog integration tests #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to validate TLOG journal fields are added as expected using the default journal writer configuration.
Add test to validate the expected journal priority field is written when the --journal-priority argument is used.
Add test to validate the expected syslog priority and facility fields when the --syslog-priority and --syslog-facility arguments are used.
justin-stephenson
force-pushed
the
jstephen_add_journal_syslog_tests
branch
from
b19853c
to
46a325f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests to complete the following:
I started writing code for the syslog test to handle non-Red Hat based linux distributions but discarded it as (currently) the integration test setup will not work for non-red hat systems.
@sabbaka @spoore1 @spbnick Could you please review?