Skip to content

Commit

Permalink
Revert "Fixed project import logic and dashboard locator (eclipse-che…
Browse files Browse the repository at this point in the history
…#22516)" (eclipse-che#22532)

This reverts commit e84b2f5.

Signed-off by ScrewTSW <tdancs@redhat.com>
  • Loading branch information
ScrewTSW committed Sep 20, 2023
1 parent e84b2f5 commit 05aa417
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion tests/e2e/pageobjects/dashboard/Workspaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export class Workspaces {
}

private getActionsPopupButtonLocator(workspaceName: string, buttonText: string): By {
return By.xpath(`${this.getWorkspaceListItemLocator(workspaceName)}//button[text()='${buttonText}']`);
return By.xpath(`${this.getWorkspaceListItemLocator(workspaceName)}//li[@role='menuitem']//button[text()='${buttonText}']`);
}

private getOpenButtonLocator(workspaceName: string): By {
Expand Down
8 changes: 3 additions & 5 deletions tests/e2e/specs/SmokeTest.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,12 @@ suite(`The SmokeTest userstory`, async function (): Promise<void> {
});
test('Check a project folder has been created', async function (): Promise<void> {
const projectName: string = StringUtil.getProjectNameFromGitUrl(factoryUrl);
projectSection = (await new SideBarView().getContent().getSections())[0]; // get the (WORKSPACE) section from the sidebar - contains project content
expect(await projectSection.findItem(projectName)).not.eqls(undefined);
projectSection = await new SideBarView().getContent().getSection(projectName);
Logger.debug(`new SideBarView().getContent().getSection: get ${projectName}`);
});
test('Check the project files was imported', async function (): Promise<void> {
Logger.debug(`projectSection.findItem: find ${BaseTestConstants.TS_SELENIUM_PROJECT_ROOT_FILE_NAME}`);
const isFileImported: ViewItem | undefined = await projectSection.findItem(
BaseTestConstants.TS_SELENIUM_PROJECT_ROOT_FILE_NAME
);
const isFileImported: ViewItem | undefined = await projectSection.findItem(BaseTestConstants.TS_SELENIUM_PROJECT_ROOT_FILE_NAME);
expect(isFileImported).not.eqls(undefined);
});
test('Stop the workspace', async function (): Promise<void> {
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/utils/StringUtil.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import { injectable } from 'inversify';
import { Logger } from './Logger';
import { KubernetesCommandLineToolsExecutor } from './KubernetesCommandLineToolsExecutor';

@injectable()
export class StringUtil {
Expand Down

0 comments on commit 05aa417

Please sign in to comment.