Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New addon: Default to bitmap mode #7259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mybearworld
Copy link
Contributor

Resolves #7201

Changes

When the empty vector is added, an empty bitmap is added instead.

Reason for changes

Saves a click for people who often use bitmap

Tests

Tested in Edge.

@CST1229
Copy link
Member

CST1229 commented Mar 10, 2024

I think this might also trigger when importing an empty vector? Though that's an extremely minor bug and something no one will ever do unless they're intentionally triggering the bug.

@mybearworld
Copy link
Contributor Author

I think this might also trigger when importing an empty vector? Though that's an extremely minor bug and something no one will ever do unless they're intentionally triggering the bug.

I'm not sure why, but when uploading the empty SVG yourself, the hash is 4b7a854341abd530a6780bfb6a68627c.svg, which doesn't trigger the replacing.

@Samq64 Samq64 added type: enhancement New feature for the project new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons labels Mar 10, 2024
@WorldLanguages
Copy link
Member

I think this might also trigger when importing an empty vector?

Even if it did, it's not a big deal. This looks like the simplest way to implement the addon.

@WorldLanguages
Copy link
Member

@mybearworld Thanks for the PR, I'll quickly review it. Prioritizing a bit, as this was directly requested through user feedback multiple times, and it's a quite simple implementation.

@WorldLanguages
Copy link
Member

Should we extend this so that it also defaults to bitmap when creating a new sprite/backdrop with the "paint" button?

@mybearworld
Copy link
Contributor Author

Should we extend this so that it also defaults to bitmap when creating a new sprite/backdrop with the "paint" button?

That would make sense.

@mybearworld
Copy link
Contributor Author

When trapping vm.addSprite to make it add the bitmap instead of the vector, the bitmap gets zoomed in for some reason:
image

@WorldLanguages
Copy link
Member

WorldLanguages commented Mar 11, 2024

When trapping vm.addSprite to make it add the bitmap instead of the vector, the bitmap gets zoomed in for some reason

Maybe we should wait until the user goes to the Costumes tab, and just emulate a button click on the "convert to bitmap" button 🤔 (once for sprite, only if the sprite was created within this session)

@mybearworld
Copy link
Contributor Author

That's not an instant conversion, though. It's noticable.

@WorldLanguages
Copy link
Member

That's not an instant conversion, though. It's noticable.

Hmm, good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new addon Related to new addons to this extension. `scope: addons` should still be added. scope: addon Related to one or multiple addons type: enhancement New feature for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New addon: default new costumes to bitmap, instead of vector
5 participants