New addon: Hide avdertising comments

[Jazza-231]

Resolves community suggestion

Changes

Adds a new addon that hides comments that contain certain strings deemed as advertising by the user. Presets are supplied.

Reason for changes

Advertising is so so prevelant on scratch, and it is really annoying to see. Since reporting on the user's behalf is not a good idea, hiding them is the next best idea.

Tests

Wroks on the latest version of brave.

ToDo

Add the option to replace the offending text with something like [Marked as advertising], with the option to show it when clicked on.
Change logic for what to hide, only hide the whole thread of messages if the top is advertising, not if advertising is present in any of the thread
Fix the problem outlined here HELP!!!

[Jazza-231]

Odd thing, on the profile, for some reason it can not hide more than one comment like this:

but it can hide more than one reply, like this:

This doesnt happen at all on project pages (or studios) (and obviously i set "elephant" to be classified as advertising)

[DNin01]

Should probably be discussed at least a little bit. Completely hiding comments means you can't report them, so this could potentially backfire on the community.

[Samq64]

Related:

• Hide comments/projects/studios by specific users #3810
• Keyword-based spoiler warnings #5954

[Jazza-231]

Should probably be discussed at least a little bit. Completely hiding comments means you can't report them, so this could potentially backfire on the community.

If you check the todo, i have adresses this: Add the option to replace the offending text with something like [Marked as advertising], with the option to show it when clicked on.

[Jazza-231]

          if (addon.settings.get("method") === "censor" && !url.includes(settings["profiles"])) {
            const commentReply = await addon.tab.waitForElement("div.replies>div.comment", { markAsSeen: true });
            console.log("Checing replies");
            matches.forEach((match) => {
              if (dsis(commentReply, match)) {
                handleComment(commentReply);
              }
            });
          }

This code seems to be causing problems, im not entirely sure why but when this is not commented out, it can only manage to mark a few comments as advertising before it breaks? im not too sure why. People tend to advertise in replies a lot less than normal comments, so this isnt too big of an issue, but if anyone knows whats going on that would be great

[Jazza-231]

This is the new setting for censoring instead of hiding

[Jazza-231]

Please see this message in the SA dev server

[Jazza-231]

only issue now is the profiles when you choose censor

[Waakul]

Why did'nt you sync to upstream before creating the branch?, there are conflicts now.

[Jazza-231]

Why did'nt you sync to upstream before creating the branch?, there are conflicts now.

I've been meaning to ask about this, i keep my master branch up to date, and i create new branches off the master, but for some reason it doesnt seem to be up to date? im not sure why

[DNin01]

Why did'nt you sync to upstream before creating the branch?, there are conflicts now.

I've been meaning to ask about this, i keep my master branch up to date, and i create new branches off the master, but for some reason it doesnt seem to be up to date? im not sure why

Next time, try pulling from upsteam/master. You'll get the latest changes not just from your fork's master branch but from the source repository.

[Chiroyce1]

I'd say remove the hide option entirely, if this addon is enabled the only thing it should be doing is replace it's content with [Marked as advertising] but without hiding any extra information like the username or timestamp (both of which aren't present in your screenshots) - hiding comments might potentially block false positives or as DNin01 said you wouldn't be able to report or delete them.

[Jazza-231]

I'd say remove the hide option entirely, if this addon is enabled the only thing it should be doing is replace it's content with [Marked as advertising] but without hiding any extra information like the username or timestamp (both of which aren't present in your screenshots) - hiding comments might potentially block false positives or as DNin01 said you wouldn't be able to report or delete them.

It defaults to censoring, I believe they should have the choice to hide them fully, as multiple people have expressed wanting that (and the extra info including message comment is accessible by clicking on the censored comment)

[DNin01]

I believe they should have the choice to hide them fully, as multiple people have expressed wanting that

I think some people will appreciate customization options that reduce visual clutter, but with great power comes great responsibility. It also means that if a comment is flagged incorrectly, you won't be able to see it.

One option would be to somehow warn users that when using this option, these comments will become impossible to report or read.

For signed-out users, I don't see this being a problem, as you have to sign in to report comments.

[Jazza-231]

I believe they should have the choice to hide them fully, as multiple people have expressed wanting that

I think some people will appreciate customization options that reduce visual clutter, but with great power comes great responsibility. It also means that if a comment is flagged incorrectly, you won't be able to see it.

One option would be to somehow warn users that when using this option, these comments will become impossible to report or read.

For signed-out users, I don't see this being a problem, as you have to sign in to report comments.

I agree, I'll add a warning for it. (And oh my god signed out users, someone remind me to test it for them...)

I was also thinking some more accurate matching like blocking links on projects only, but that seems it might get a bit too complex visually, I think this is a good alternative. Plus, you can always disable the addon temporarily to see what is hidden, cuz dynamic enable and disable is supported now

[mybearworld]

Could this maybe be an issue for vision impaired users?

[Jazza-231]

they have the addon on, they know its supposed to hide potential adevertising. Plus, comments are not very vision impaired friendly anyway. I can of course make that a setting but i really dont think thats needed

[Waakul]

l10n means localization (l, then 10 letters, then n)

[Jazza-231]

l10n means localization (l, then 10 letters, them n

weird

[Jazza-231]

In case you cant tell im just going through my prs, any word on this one?

[Waakul]

It could show a dropdown like "5 messages marked as advertising" like blocked messages in discord.

[Jazza-231]

It could show a dropdown like "5 messages marked as advertising" like blocked messages in discord.

I am not doing that. Very difficult, tried before

[Waakul]

It could show a dropdown like "5 messages marked as advertising" like blocked messages in discord.

I am not doing that. Very difficult, tried before

set display of the marked as advertising messages to none, add a button " marked as advertising". Add a click event to that and create a toggle variable. then below that add an if condition to set display to none or whatever is needed.

[Jazza-231]

It could show a dropdown like "5 messages marked as advertising" like blocked messages in discord.

I am not doing that. Very difficult, tried before

set display of the marked as advertising messages to none, add a button " marked as advertising". Add a click event to that and create a toggle variable. then below that add an if condition to set display to none or whatever is needed.

...have you even tested the addon at all? try knowing what you're talking about before correcting someone. the marked as advertising text is a button which shows the comment and replies. I am not adding the count

[Waakul]

It could show a dropdown like "5 messages marked as advertising" like blocked messages in discord.

I am not doing that. Very difficult, tried before

set display of the marked as advertising messages to none, add a button " marked as advertising". Add a click event to that and create a toggle variable. then below that add an if condition to set display to none or whatever is needed.

...have you even tested the addon at all? try knowing what you're talking about before correcting someone. the marked as advertising text is a button which shows the comment and replies. I am not adding the count

I meant merging it into one single button not wrapped in a comment container, instead showing multiple buttons in comments.