Bug-fix (minor?) addons group #7242

DNin01 · 2024-03-03T00:39:25Z

Resolves #2617, resolves #7152

Changes

Adds a group to the addon list in the settings page called "Bug fixes" (we can change this as we see fit). These addons...

do not appear under Enabled, but can still be searched
show a confirmation before disabling

Reason for changes

Some addons fix bugs and those addons deserve to be enabled by default, but that would also clutter the "Enabled" group in the list of addons. The "bug fixes" group allows us to set them aside, making more room for addons that users would actually want to take a look at.

Tests

Tested on Edge 122.

To-Dos

Update the manifest schema
What should we do with these addons in the extension popup's "Addons on this tab" group?
What should we do with fix-uploaded-svgs?

We might also want to address any confusion around why these addons aren't showing up under "Enabled".

For the addon setting migration process

DNin01 · 2024-03-03T00:40:04Z

webpages/settings/index.js

I also have written code for enabling fix-uploaded-svgs for 10% of users, but I'm not sure if I want to include that in this PR without some discussion first.

@WorldLanguages, how do you feel about this?

For ten percent of users? What does that mean?

For ten percent of users? What does that mean?

Just using Math.random() and if it's less than 0.1, enable it if it's currently not, otherwise don't. (As part of the migration logic for transitioning to v1.37 or whenever)

The point being, it would reduce the impact of any undetected bugs in the addon. (After what happened with Faster project loading)

Anyway, do you have any opinions on enabling an addon by default for a subset of users? Should we do that at all or just enable it for everyone?

how do you feel about this?

I know it's been brought up before but I feel like this is the sort of thing that a beta version would help us solve. Google does staggered rollouts for basically everything and it's super annoying because even if I want a new feature I have no choice but to wait.

Just using Math.random() and if it's less than 0.1

Hmm... Sounds weird

Just using Math.random() and if it's less than 0.1

Hmm... Sounds weird

Probably should open an issue first for that, then.

Samq64 · 2024-03-03T00:48:41Z

Related open PR: #4515

Samq64 · 2024-03-03T00:52:09Z

addons/disable-sprite-wobble/addon.json

@@ -48,8 +48,8 @@
      "default": "none"
    }
  ],
-  "tags": ["editor", "recommended"],
-  "enabledByDefault": false,
+  "tags": ["editor", "recommended", "minor"],


This is the only addon with a setting and the new tag.

TODO:

If the disable-sprite-wobble addon gets enabled automatically, the "mode" setting should be reset.

DNin01 · 2024-03-03T01:05:40Z

background/get-addon-settings.js

@@ -686,10 +695,16 @@ chrome.storage.sync.get([...ADDON_SETTINGS_KEYS, "addonsEnabled"], (storageItems

    // Finally, minify the settings and store them in the scratchAddons object
    const prerelease = chrome.runtime.getManifest().version_name.endsWith("-prerelease");
+    const currentVersion = chrome.runtime.getManifest().version;
+    console.log(`Transitioned from ${lastVersionStr} \u2192 ${currentVersion}`);


Maybe should only log this if changes were made.

Samq64 · 2024-03-03T01:14:48Z

What should we do with Better editor comments?

There are also a couple forum bugfix addons:

Redirect to standard forums
Remember collapsed forum categories

DNin01 · 2024-03-03T01:19:33Z

What should we do with Better editor comments?

I know, right?

There are also a couple forum bugfix addons:

Redirect to standard forums

I'll include that once #6915 is merged. It changes the addon ID.

Remember collapsed forum categories

That one I think might be best left for the user to decide on, but maybe.

WorldLanguages · 2024-03-10T21:36:50Z

Does this actually resolve #7152? I thought that issue was about using setting descriptions and a single addon for most bug fixes.

Hans5958 · 2024-03-11T13:46:13Z

Does this actually resolve #7152? I thought that issue was about using setting descriptions and a single addon for most bug fixes.

It doesn't resolve the issue but will close the issue nonetheless as it won't be implemented because other alternatives has been chosen.

Secret-chest · 2024-03-12T14:51:31Z

forum bugfix

This would also be the right time to change forums to a website subcategory and not a group.

DNin01 · 2024-03-12T18:35:36Z

forum bugfix

This would also be the right time to change forums to a website subcategory and not a group.

I think the main reason the forum addons are in a separate group is because not everyone uses the forums and the forums are a smaller area of the entire website.

mxmou · 2024-03-12T19:53:46Z

not everyone uses the forums

Almost no one uses the forums.

DNin01 · 2024-03-12T21:54:10Z

not everyone uses the forums

Almost no one uses the forums.

Yeah, that's a better way of putting it. 😄

Secret-chest · 2024-03-13T09:19:31Z

I think the main reason the forum addons are in a separate group is because not everyone uses the forums and the forums are a smaller area of the entire website.

We could just make it list them at the bottom.

mxmou · 2024-03-13T16:52:45Z

I think the main reason the forum addons are in a separate group is because not everyone uses the forums and the forums are a smaller area of the entire website.

We could just make it list them at the bottom.

The way addons are sorted is already confusing: #3012

Secret-chest · 2024-03-13T20:09:15Z

Then let's just put forum bugfix addons as a bugfix.

_locales/en/messages.json

mxmou · 2024-03-24T20:36:29Z

I don't think addons in the bug fixes group need the "recommended" tag.

What should we do with these addons in the extension popup's "Addons on this tab" group?

There could be a separate "bug fixes on this tab" group below "addons on this tab".

WorldLanguages · 2024-03-24T22:09:57Z

Just a comment: I haven't seen this PR in detail yet, but if there's consensus in favor of this I will just merge it :)

WorldLanguages · 2024-03-24T22:12:56Z

Adds a group to the addon list in the settings page called "Bug fixes" (we can change this as we see fit). These addons...

do not appear under Enabled, but can still be searched

show a confirmation before disabling

Personally, I think this is a good idea. As these bug-fix addon usually don't have settings and there's no good reason to disable them, I don't see the point of listing them in the "enabled" group. These should, however, still be listed within the "addons (running) on this tab" group when using the settings page from the popup.

Co-authored-by: Maximouse <51849865+mxmou@users.noreply.github.com>

DNin01 added 3 commits March 2, 2024 15:47

Add "bug fixes" group to addon list

6449032

Store last extension version

5f8145b

For the addon setting migration process

Categorize some addons as bug fixes

cc1f287

DNin01 added type: enhancement New feature for the project scope: addon.json About the addon.json file structure scope: webpages Related to the web pages (settings page, pop-up, etc) scope: user experience Related to the user experience (UX) aspect of the extension labels Mar 3, 2024

DNin01 requested review from Hans5958 and mxmou March 3, 2024 00:39

DNin01 requested review from WorldLanguages and apple502j as code owners March 3, 2024 00:39

DNin01 commented Mar 3, 2024

View reviewed changes

DNin01 changed the title ~~Minor addons group~~ Bug-fix (minor?) addons group Mar 3, 2024

Samq64 reviewed Mar 3, 2024

View reviewed changes

DNin01 commented Mar 3, 2024

View reviewed changes

Hans5958 removed their request for review March 16, 2024 09:26

mxmou reviewed Mar 24, 2024

View reviewed changes

_locales/en/messages.json Outdated Show resolved Hide resolved

Fix "undesireable" typo

ac496c6

Co-authored-by: Maximouse <51849865+mxmou@users.noreply.github.com>

WorldLanguages mentioned this pull request Apr 3, 2024

Merge big-save-button with custom-menu-bar #7260

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug-fix (minor?) addons group #7242

Bug-fix (minor?) addons group #7242

DNin01 commented Mar 3, 2024

DNin01 Mar 3, 2024

DNin01 Mar 4, 2024

WorldLanguages Mar 6, 2024

DNin01 Mar 7, 2024

BroJac5246 Mar 7, 2024

WorldLanguages Mar 10, 2024

DNin01 Mar 10, 2024

Samq64 commented Mar 3, 2024

Samq64 Mar 3, 2024

DNin01 Mar 3, 2024

DNin01 Mar 3, 2024

Samq64 commented Mar 3, 2024

DNin01 commented Mar 3, 2024

WorldLanguages commented Mar 10, 2024

Hans5958 commented Mar 11, 2024

Secret-chest commented Mar 12, 2024

DNin01 commented Mar 12, 2024

mxmou commented Mar 12, 2024

DNin01 commented Mar 12, 2024

Secret-chest commented Mar 13, 2024

mxmou commented Mar 13, 2024

Secret-chest commented Mar 13, 2024

mxmou commented Mar 24, 2024

WorldLanguages commented Mar 24, 2024

WorldLanguages commented Mar 24, 2024

Bug-fix (minor?) addons group #7242

Are you sure you want to change the base?

Bug-fix (minor?) addons group #7242

Conversation

DNin01 commented Mar 3, 2024

Changes

Reason for changes

Tests

To-Dos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Samq64 commented Mar 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Samq64 commented Mar 3, 2024

DNin01 commented Mar 3, 2024

WorldLanguages commented Mar 10, 2024

Hans5958 commented Mar 11, 2024

Secret-chest commented Mar 12, 2024

DNin01 commented Mar 12, 2024

mxmou commented Mar 12, 2024

DNin01 commented Mar 12, 2024

Secret-chest commented Mar 13, 2024

mxmou commented Mar 13, 2024

Secret-chest commented Mar 13, 2024

mxmou commented Mar 24, 2024

WorldLanguages commented Mar 24, 2024

WorldLanguages commented Mar 24, 2024