New Addon: Asset Conflict Resolution Dialog

[Joeclinton1]

Resolves #7177

Changes

asset-conflict-dialog.mp4

Reason for changes

For projects with assets created via external editors, it is often neccessary to replace the existing costumes with updated versions. Currently you need to delete the old ones, then import the new ones. This is tedious, so this accelerates that process.

Tests

I have tested:

• Importing a single costume and renaming/replacing/skipping
• Importing multiple costumes and renaming/replacing WITHOUT "do this for all conflicts"
• Importing multiple costumes and renaming/replacing/skipping WITH "do this for all conflicts"
• Importing a single/multiple sounds(s) and renaming/replacing (with for all conflicts if multiple)
• Closing the modal for costume/sounds (desired behaviour is to skip all)
• It's compatible with 'file-drag-and-drop' and'dark-mode' and 'folders' addons
• works with dynamic enable/disable
• works with dragging an asset from one sprite to another
• when an asset is replaced it gets selected
• works when dragging costume/sound from backpack

[medlans]

Related thing that used to exist in 2.0 (basically you could just clear and then import into the costume): #5083

[Joeclinton1]

Related thing that used to exist in 2.0 (basically you could just clear and then import into the costume): #5083

Does this possibly also resolve that issue? It's not the desired design but it solves the same issue and potentially better as long as the names are the same.

[medlans]

Related thing that used to exist in 2.0 (basically you could just clear and then import into the costume): #5083

Does this possibly also resolve that issue? It's not the desired design but it solves the same issue and potentially better as long as the names are the same.

The import button in 2.0 would add the uploaded thing to the costume instead of replacing, but you had to clear it first to do this, so they're a bit different. There was also the add button in 2.0, which was similar but you would select costumes/backdrops from the library instead.
Edit: Also the poster said the initial description was outdated.

[GarboMuffin]

I haven't looked at the objects but a simple solution that should work most of the time would be checking if asset.name is addon.tab.redux.state.locales.messages['gui.sharedMessages.costume'].replace('{index}', '1') (and also check gui.sharedMessages.backdrop) or "recording1" (always English) before the folders addon compatibility runs. obviously that's not ideal - but if there's nothing better

[Joeclinton1]

I haven't looked at the objects but a simple solution that should work most of the time would be checking if asset.name is addon.tab.redux.state.locales.messages['gui.sharedMessages.costume'].replace('{index}', '1') (and also check gui.sharedMessages.backdrop) or "recording1" (always English) before the folders addon compatibility runs. obviously that's not ideal - but if there's nothing better

The assetObj has a very tell tale signature when it's a new costume, just checking if it's the same for sounds right now. Don't want to use the name for sure.

[Joeclinton1]

I tested this more extensively and found no bugs when using the sprite folders addon. As far as I am aware this works as expected.

[GarboMuffin]

No dialog if I drag in a conflicting costume from the backpack

edit: Pretty sure that worked before so think it's related to the check for if someone pressed the new costume button (did not look)

[WorldLanguages]

No dialog if I drag in a conflicting costume from the backpack

Oof... nice catch
RIP when this addon was less than 200 lines long

[Joeclinton1]

No dialog if I drag in a conflicting costume from the backpack

Oof... nice catch RIP when this addon was less than 200 lines long

As Garbo hinted at this is probably a side effect of the previous fix. I tested quite a few ways of adding the costume and thought the signature was specific to the new costume, but it's possible dragging from backpack has the same signature.

[Samq64]

Dropping files onto the backdrop pane or uploading them outside the costume editor doesn't trigger the dialog.

[Joeclinton1]

Dropping files onto the backdrop pane or uploading them outside the costume editor doesn't trigger the dialog.

Will fix when I have some free time

[Joeclinton1]

Dropping files onto the backdrop pane or uploading them outside the costume editor doesn't trigger the dialog.

I can reproduce the first thing, but I don't understand what you mean by the second. Could you please clarify this?

Edit: Was able to replicate the second part

[Joeclinton1]

Making it work for the backdrop was quite easy. It is unfortunate Scratch chose to have a separate add backdrop function.

[Samq64]

I haven't taken a full look at all the code but drag and drop, sounds, backdrop and HD uploads all work fine.