I will begin implementing this addon today hopefully.

"a textbox that is auto filled with what it would have been renamed to without the addon", this doesn't make sense when uploading multiple files.

I suggest no textbox and instead there's just an option to rename.

Here's my research notes on how everything works:

1. The relevant code for the renaming is:
   a. vm.addCostume() -> target.addCostume() ->sprite.addCostumeAt() and target.addSound()
   b. this occurs at the VM level. This makes it difficult to modify the behaviour per costume.
2. The code that calls these occurs higher up in the GUI level at:
   a. handleNewCostume and handleSoundUpload
3. These are called by fileUploader during:
   a. here for costumes and here for sounds

I really don't want the addon to do it's own check for duplicates, as that adds redundancy. If we can use the result of the VM's name duplication check directly it will be better. With this in mind, here's my idea:

pseudo code:

conflictQueue = []

// this called higher up and we don't want to pollute it
// for costume in costumes {
// file.onLoad(()=>createNewCostume(costume);
// }


function addCostumeAt(costume, choice=None) {
// Check for renames.
if (renameRequired && choice == None) {
    const conflict = (args, (choice) =>{addCostumeAt(costume, choice)})
    conflictQueue.push(conflict);
    if(conflictQueue.length==1){
       dequeueConflictModal();
    }    
    return true;
} else if ( renameRequired){
   switch (choice) {
    case 'skip':
        // Skip this costume
        return;
    case 'replace':
        // Delete conflicting and proceed
        break;
    default:
        pass;
   }
}
// Rest of logic for costume creation
}

function dequeueConflictModal(callback) {
[args, callback] = conflictQueue.shift()
// Create and display modal using 'args' which calls 'callback' with choice when user submits dialog
if(conflictQueue){
  dequeueConflictModal();
}
}

This can also happen when importing sprites, and also when renaming any costumes.

A much simpler way that wouldn't require overriding all those functions would be to override StringUtil.unusedName, but I don't think that that's accessible from the outside.

This can also happen when importing sprites, and also when renaming any costumes.

A much simpler way that wouldn't require overriding all those functions would be to override StringUtil.unusedName, but I don't think that that's accessible from the outside.

Even we could pollute it, it's not enough. The very act of replacing requires us to delete an existing costume, or alternatively to change it's costume object instead of adding a new one but either way polluting this isn't going to solve that.

I am not going to do this for importing sprites as it's too much work and not useful. Same goes for renaming.

The very act of replacing requires us to delete an existing costume, or alternatively to change it's costume object instead of adding a new one but either way polluting this isn't going to solve that.

StringUtil.unusedName is called in every context where a costume is created or changed. We wouldn't need to replace any costume objects it this were possible.

The very act of replacing requires us to delete an existing costume, or alternatively to change it's costume object instead of adding a new one but either way polluting this isn't going to solve that.

StringUtil.unusedName is called in every context where a costume is created or changed. We wouldn't need to replace any costume objects it this were possible.

I don't think you understand what is required here. We must replace the costume/sound object. That is just a dumb util function to get the first unused name in a list of names. It's clearly the wrong function to pollute.

Code is written, will begin debugging and hopefully testing tomorrow.

Am I misunderstanding what this is about? Isn't this exactly about overriding StringUtil.unusedName's behavior? When a name is already used, it shouldn't fall back on adding 2 to it, but instead ask the user for a different name. Right?

Am I misunderstanding what this is about? Isn't this exactly about overriding StringUtil.unusedName's behavior? When a name is already used, it shouldn't fall back on adding 2 to it, but instead ask the user for a different name. Right?

The OP wants to be able to skip, replace or rename the asset. Overriding unusedName would only allow renaming.

Am I misunderstanding what this is about? Isn't this exactly about overriding StringUtil.unusedName's behavior? When a name is already used, it shouldn't fall back on adding 2 to it, but instead ask the user for a different name. Right?

The OP wants to be able to skip, replace or rename the asset. Overriding unusedName would only allow renaming.

Ah, I see, sorry.

The addon implementation is getting closer to done, but it's definitely far from easy like I first thought it would be.

I just realized I need to be polluting vm.addCostume() and vm.addSound() instead of the lower level things since they'll break if they think a costume/sound has been added but it actually hasn't. Also I need to handle which costume to select if no costume was added, and when to call emitProjectChanged or emitTargetsUpdate