Migrates project submission to judging #58
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| setTeamMembers([email]); | ||
| } | ||
| }, [project, email]); | ||
| const { isLoading, mutate: saveProject } = |
There was a problem hiding this comment.
need to have some failure logic to let the user know some of the inputs are incorrect
src/server/api/routers/projects.ts
Outdated
| teamMembers = await Promise.all(teamMembersPromise); | ||
| } else { | ||
| const teamMembersPromise = input.teamMembers.map(async (email) => { | ||
| const user = await ctx.prisma.user.findFirst({ |
There was a problem hiding this comment.
what if the user is already in a team?
There was a problem hiding this comment.
I don't understand what the concern is here. This is the local auth case, so all we're doing is checking that the provided team member emails are in the User collection.
There was a problem hiding this comment.
I think if the user is in a team, they will be reassigned to the new team, which shouldnt happen
| ); | ||
| } | ||
|
|
||
| const judgingInstance = await ctx.prisma.judgingInstance.upsert({ |
There was a problem hiding this comment.
need to set sigma to the sigma from the settings
There was a problem hiding this comment.
Why are we letting the admin set sigma2 but not mu?
There was a problem hiding this comment.
Mu is used for ranking, my understanding is as long as all mus are the same, the actual values don't matter. The sigmas represent how confident we are about the judging results, which is what we want to change
resolves #54
Project details submit/save complete, need to do prize submission