Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv-v3-git: Add Version 20230430 #1187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

b4imetu
Copy link
Contributor

@b4imetu b4imetu commented May 1, 2023

Closes ScoopInstaller/Extras#11123

Relates to ScoopInstaller/Extras#11123

& Removed 32-bit architecture

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

All changes look good.

Wait for review from human collaborators.

mpv-v3-git

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

All changes look good.

Wait for review from human collaborators.

mpv-v3-git

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@b4imetu
Copy link
Contributor Author

b4imetu commented Jun 8, 2023

ScoopInstaller/Extras#11123

What do you think of this pr? @brian6932 @HUMORCE

@brian6932
Copy link
Contributor

brian6932 commented Jun 8, 2023

It's fine. I'm leaning towards the side that it should just be apart of mpv-git, as opposed to a separate manifest tho, how many people even have > 10 year old CPUs? CPUs with these instruction sets are very common nowadays.

If anything, I would prefer that v3 would be the default experience, and that if a manifest was to be added to the versions bucket, it should be the legacy one currently in use. Imo, compilation with modern instruction sets should be the default binary experience.

@b4imetu
Copy link
Contributor Author

b4imetu commented Jun 9, 2023

@brian6932 I agree with what you said.
However, the developer of mpv has yet to release a stable version of mpv-v3. Given that the stable version still defaults to the old mpv, I think they may want to reach a wider user base (and there is little difference between the two in terms of usage).
Of course, since mpv-git users tend to enjoy trying new things, I also agree with making v3 the default option for mpv-git.

In order to use mpv-v3 on scoop, I hope that the maintainers of scoop will include it as soon as possible. Any PR would be greatly appreciated. Thank you! @HUMORCE

brian6932 added a commit to brian6932/Versions that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants