Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(install): Separate archive extraction from downloader #5951

Merged
merged 3 commits into from
May 12, 2024
Merged

refactor(install): Separate archive extraction from downloader #5951

merged 3 commits into from
May 12, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 9, 2024 •
edited

Description

Separate archives extraction function from downloader (Invoke-ScoopDownload())

Motivation and Context

How Has This Been Tested?

scoop install and scoop update work fine.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven mentioned this pull request May 9, 2024
Merged
5 tasks
@niheaven niheaven marked this pull request as ready for review May 10, 2024 05:27
@niheaven niheaven merged commit a5bd229 into develop May 12, 2024
2 checks passed
@niheaven niheaven deleted the refactor-extraction branch May 12, 2024 10:47
@brian6932 brian6932 mentioned this pull request May 20, 2024
Open
@lewis-yeung lewis-yeung mentioned this pull request May 21, 2024
Merged
5 tasks
brian6932 pushed a commit to brian6932/Scoop that referenced this pull request Jun 1, 2024
@niheaven @brian6932
refactor(install): Separate archive extraction from downloader (Scoop…
c906219 
…Installer#5951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@niheaven