Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): Limit HTTP redirects #5758

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gitolicious
Copy link
Contributor

Description

When a misconfigured download server responds with invalid/infinite redirects, Scoop follows them and gets stuck in a loop. This PR limits the redirects to 20.

Motivation and Context

Closes #5757

How Has This Been Tested?

  1. Create manifest https://www.screenpresso.com/binaries/releases/stable/dotnet47/Screenpresso.exe as the url.
  2. Run scoop update screenpresso with original install.ps1 -> infinite loops are being followed.
  3. Run scoop update screenpresso with install.ps1 from this PR -> error is thrown after 20 redirects.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant