fix(checkver) use Start-Job for manifest script to not to exit on break #5407
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke-Command will exit the parent process if a manifest script issues a break command. Use Start-Job to resolve this. Fixes ScoopInstaller/GithubActions#32
|
This didn't used to happen before, did something change in GitHub Actions? /cc @niheaven |
1 task
|
Nope, this part hasn't been changed. |
This was referenced Feb 27, 2023
|
This could skip A better way is NEVER use |
I disagree. randoms should not be be able to run something in the parent namespace. security says no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the method
checkverruns manifest scripts to useStart-Jobinstead ofInvoke-Command. When usingInvoke-Commandif the script calls abreakthe parent process will exit.See: Do not use break outside of a loop, switch, or trap
Motivation and Context
Currently autoupdating is broken on all Scoop buckets that have a manifest that runs a
breakin the autoupdate script portion. Once one manifest is run that has issued a break the Github action will exit and the rest of the bucket will fail to update.This change starts the manifest script as a separate job allowing the parent process to continue after the manifest script exits, and letting the github action to finish updating the buckets.
How Has This Been Tested?
I ran the change on my copy of the current (3579b11f99c692f6b68c1ce5119b8e5d6db9f2bb) Extras repo. I have attached the output of the update here. Compare with the current log of Excavator ran during the same period:
See where it fails on
librewolf. That manifest issues abreakcommand. My local bucket updated 84 manifests.Checklist:
developbranch.