Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support mirror configuration #4406

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jilliss
Copy link

@jilliss jilliss commented Jul 11, 2021

Sometimes the address in the bucket becomes invalid or inaccessible
Or it may be slow to visit in some areas, such as China

I modified the url parsing script and now it will parse the mirrirs property in config.json. which is a map type property
Below is my config.jsonfile

{
  "SCOOP_BRANCH": "master",
  "lastupdate": "2021-07-11T10:33:24.5707181+08:00",
  "SCOOP_REPO": "https://github.com/lukesampson/scoop",
  "aria2-enabled": false,
  "list": "all",
  "proxy": "127.0.0.1:10809",
  "mirrors": {
    "http://repo.msys2.org/": " https://repo.huaweicloud.com/msys2/"
  }
}

At this time, scoop will download files from repo.huaweicloud.com instead of repo.msys2.org

@jilliss
Copy link
Author

jilliss commented Jul 11, 2021

@r15ch13 Can you help me see if there is a problem?
There seems to be something wrong with the automated test script

@niheaven
Copy link
Member

Please search https://github.com/chawyehsu/dorado for mirrors in China, and submit PR if any need.

@jilliss
Copy link
Author

jilliss commented Jul 12, 2021

What I want is to change the location of the package download through configuration. Instead of downloading the json file in the bucket from gitee or from github
This PR is to replace the url by reading the configuration file

Copy link

@StarsbySea StarsbySea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very supportive of this addition, at times the network may incorrectly block certain domains and with this feature it is possible to configure mirror sites for certain domains so that the download and installation can run successfully. Of course a specific example is speeding up downloads from Github in China, but obviously there are many more use cases.
However, this may need more work, such as providing an option in the scoop config to manually add the domains that need to be mirrored. See the discussion at #4264 (comment).
I wonder if the original author would be interested in continuing to implement this feature?
Also please consider changing the target branch to develop

@HUMORCE HUMORCE mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants