Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycharm: fix creation of virtualenv #8359

Merged
merged 4 commits into from
Apr 21, 2022
Merged

pycharm: fix creation of virtualenv #8359

merged 4 commits into from
Apr 21, 2022

Conversation

alealexpro100
Copy link
Contributor

Closes #6884

@alealexpro100
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

pycharm-professional

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

pycharm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@issaclin32 issaclin32 changed the title pyhcarm: fix creation of virtualenv pycharm: fix creation of virtualenv Apr 21, 2022
@rashil2000
Copy link
Member

Could you explain how using a bat file to launch the same executable fixes the issue?

@alealexpro100
Copy link
Contributor Author

alealexpro100 commented Apr 21, 2022 •
edited

The issue looks like this.
Pointing to the real location without any symlinks allows pycharm's virtualenv helper to work correctly.
It can be easily reproduced by running something like this:
C:\Users\User\scoop\apps\python\current\python.exe -S C:\Users\User\scoop\apps\pycharm\current\IDE\plugins\python-ce\helpers\virtualenv.pyz C:\Users\User\PycharmProjects\pythonProject1\venv
In short, running bat file causes direct launch of executable bypassing this bug.

@rashil2000
Copy link
Member

Oh, thanks for the detailed explanation!

@rashil2000 rashil2000 merged commit 92e3078 into ScoopInstaller:master Apr 21, 2022
@gigberg gigberg mentioned this pull request May 25, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issaclin32 issaclin32 issaclin32 approved these changes

@rashil2000 rashil2000 Awaiting requested review from rashil2000

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pycharm@2021.2.2: Failed to create virtual environment if run from current folder
3 participants
@alealexpro100 @rashil2000 @issaclin32