Add the zebra frame feature #2379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
changliao1025
commented
Apr 30, 2024
|
The existing failings are unrelated to the newly added feature. |
lgolston
requested changes
May 3, 2024
|
Can you also comment on which crs the function is working for? The example (https://output.circle-artifacts.com/output/job/5241a971-4eeb-4915-82f3-ba69c3cacb35/artifacts/0/docs/build/html/gallery/miscellanea/zebra_frame.html#sphx-glr-gallery-miscellanea-zebra-frame-py) shows InterruptedGoodeHomolosine and PlateCarree, but the former appears to be having issues. |
|
I will test the full list of crs in the new commit and provide the supported crs list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PL adds a function zebra_frame to the existing geoaxes class. This function can add a zebra alike frame around an existing geoaxes object.
Implications
This might affect some gridlines function behavior, specifically for the labeling.
An example is added in the examples/gridlines_and_labels folder.
This function does not support all the crs yet.