Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates to web project #718

Merged
merged 12 commits into from
May 15, 2024
Merged

Conversation

Lamothe
Copy link
Contributor

@Lamothe Lamothe commented May 6, 2024

  • Updated to .NET 8
  • Updated to Bootstrap 5.3.3
  • Use libman for client side packages
  • Enabled razor runtime compilation in dev
  • Added fav icon
  • Removed the footer
  • Added theme switcher

* Updated to Bootstrap 5.3.3
* Use libman for client side packages
* Enabled razor runtime compilation in dev
* Added fav icon
* Removed the footer
* Added theme switcher
@Lamothe
Copy link
Contributor Author

Lamothe commented May 6, 2024

For your consideration. This will be the first of many updates that I want to make to the website sample. Please note that .NET 7 is out of support in less than 2 weeks so I updated it to .NET 8 while I was in there.

@AsakusaRinne AsakusaRinne self-assigned this May 6, 2024
@AsakusaRinne AsakusaRinne added the enhancement New feature or request label May 6, 2024
@AsakusaRinne
Copy link
Collaborator

Hi, thank you for this contribution! However more than 2000 files are included in this PR, in which most of them are resource files such as icon. Is it possible to exclude them in git and fetch the files when building it instead?

@Lamothe
Copy link
Contributor Author

Lamothe commented May 6, 2024

Agreed, especially because I'm only using 6 of those icons. This is my first time using the new Bootstrap Icons, I've only used Font Awesome icons in the past. There's a way that I can get what I need from a CDN without pulling the entire module which includes the individual icon files. I'll do that for now and see if that helps.

Copy link
Collaborator

@AsakusaRinne AsakusaRinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall looks good to me except a few concerns. Could you please also update the LLama.Web readme since this PR has changed the UI?

LLama.Web/Common/ModelOptions.cs Outdated Show resolved Hide resolved
LLama.Web/Models/LLamaModel.cs Outdated Show resolved Hide resolved
@SignalRT
Copy link
Collaborator

it looks ok to me. it seems that there is a conflict in ModelOptions.cs. Could you solve this one before merge the PR?

I was thinking on introducing the capability to use Multi-Modal models on the Web UI. I would like to know your plans to change the Web UI to not duplicate work.

@AsakusaRinne
Copy link
Collaborator

Merging this PR now, thank you a lot for the contribution!

@AsakusaRinne AsakusaRinne merged commit 4192bea into SciSharp:master May 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants