Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticKernel: Correcting non-standard way of working with PromptExecutionSettings #689

Merged
merged 14 commits into from Apr 30, 2024

Conversation

zsogitbe
Copy link
Contributor

The extension of PromptExecutionSettings is not only for ChatCompletion, but also for text completion and text embedding.

@zsogitbe
Copy link
Contributor Author

Sorry for the list of commits. Until one is not merged it keeps listing all former ones... only the last commit is active here:
Correcting non-standard way of working with PromptExecutionSettings
ab8dd0d

@martindevans
Copy link
Collaborator

If you work in a separate branch in your fork and then PR just that branch you won't get a messy commit log like that. For this one, we'll just make sure to squash-and-merge so it all becomes on commit :)

…PromptExecutionSettings

can be used downstream to post-process the messages based on the requested format
Copy link
Collaborator

@AsakusaRinne AsakusaRinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me except one concern. Thank you a lot for this PR!

@AsakusaRinne AsakusaRinne merged commit 6bf010d into SciSharp:master Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants